Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add additional unit tests for long JWTs #93

Merged
merged 2 commits into from Mar 16, 2023
Merged

add additional unit tests for long JWTs #93

merged 2 commits into from Mar 16, 2023

Conversation

nareddyt
Copy link
Contributor

Verification that long claims are still decoded and verified successfully

@nareddyt nareddyt requested a review from TAOXUY March 16, 2023 19:59
@nareddyt nareddyt self-assigned this Mar 16, 2023
@TAOXUY
Copy link
Collaborator

TAOXUY commented Mar 16, 2023 •
edited

Could you provide some context? Why we need to test these? Anything constrain this lib to verify long JWTs?

@nareddyt
Copy link
Contributor Author

Could you provide some context? Why we need to test these?

Trying to debug b/271292995. There are no tests in the repo for long JWTs so adding them for future reference.

@TAOXUY
Copy link
Collaborator

TAOXUY commented Mar 16, 2023

Comment the length limit are tested against in these test cases?

@google-oss-prow google-oss-prow bot added the lgtm label Mar 16, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nareddyt, TAOXUY

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot removed the lgtm label Mar 16, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@nareddyt
Copy link
Contributor Author

Comment the length limit are tested against in these test cases?

Added extra comment describing length. Keep in mind the test case name already mentions this

@nareddyt nareddyt merged commit 79bd8b2 into google:master Mar 16, 2023
1 check passed
@nareddyt nareddyt deleted the claim-length branch March 16, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TAOXUY TAOXUY TAOXUY approved these changes

Assignees

@nareddyt nareddyt

@TAOXUY TAOXUY

Labels
approved size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nareddyt @TAOXUY