-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error for comparing wildcard results #69
Comments
shinh
added a commit
that referenced
this issue
May 2, 2016
This fixes issue #69. GNU make 3 sorts both for include and $(wildcard) while GNU make 4 doesn't.
Fixed, I think. |
zchee
pushed a commit
to zchee/kati
that referenced
this issue
Nov 29, 2016
This fixes issue google#69. GNU make 3 sorts both for include and $(wildcard) while GNU make 4 doesn't.
zchee
pushed a commit
to zchee/kati
that referenced
this issue
Nov 29, 2016
This fixes issue google#69. GNU make 3 sorts both for include and $(wildcard) while GNU make 4 doesn't.
zchee
pushed a commit
to zchee/kati
that referenced
this issue
Nov 29, 2016
This fixes issue google#69. GNU make 3 sorts both for include and $(wildcard) while GNU make 4 doesn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test case:
$ cat Android.mk
...
include $(LOCAL_PATH)/*/Android.mk
and suppose we have several sub-dirs which contain Android.mk file.
(e.g. a/Android.mk, b/Android.mk, c/Android.mk ... z/Android.mk)
Kati have been comparing a previous result of wildcard after sorted to a new result of wildcard without sorted. (https://github.com/google/kati/blob/master/regen.cc#L266)
The new result of wildcard should be also sorted before comparing with the previous one.
For now, kati dected "wildcard" results in the above cases as changed so always regenerate .ninja.
The text was updated successfully, but these errors were encountered: