Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error for comparing wildcard results #69

Closed
hooneygogo opened this issue May 2, 2016 · 1 comment
Closed

Error for comparing wildcard results #69

hooneygogo opened this issue May 2, 2016 · 1 comment

Comments

@hooneygogo
Copy link

Test case:
$ cat Android.mk
...
include $(LOCAL_PATH)/*/Android.mk

and suppose we have several sub-dirs which contain Android.mk file.
(e.g. a/Android.mk, b/Android.mk, c/Android.mk ... z/Android.mk)

Kati have been comparing a previous result of wildcard after sorted to a new result of wildcard without sorted. (https://github.com/google/kati/blob/master/regen.cc#L266)
The new result of wildcard should be also sorted before comparing with the previous one.

For now, kati dected "wildcard" results in the above cases as changed so always regenerate .ninja.
@hooneygogo hooneygogo changed the title kati compare unsorted "wildcard" results(cur) with sorted results(prev). Error for comparing wildcard results May 2, 2016
shinh added a commit that referenced this issue May 2, 2016
@shinh
Always sort glob results
9f6343c 
This fixes issue #69. GNU make 3 sorts both for include and
$(wildcard) while GNU make 4 doesn't.
@shinh
Copy link
Contributor

shinh commented May 2, 2016

Fixed, I think.

@shinh shinh closed this as completed May 2, 2016
zchee pushed a commit to zchee/kati that referenced this issue Nov 29, 2016
@shinh
Always sort glob results
ebd94d6 
This fixes issue google#69. GNU make 3 sorts both for include and
$(wildcard) while GNU make 4 doesn't.
zchee pushed a commit to zchee/kati that referenced this issue Nov 29, 2016
@shinh
Always sort glob results
c1f36f0 
This fixes issue google#69. GNU make 3 sorts both for include and
$(wildcard) while GNU make 4 doesn't.
zchee pushed a commit to zchee/kati that referenced this issue Nov 29, 2016
@shinh
Always sort glob results
120228a 
This fixes issue google#69. GNU make 3 sorts both for include and
$(wildcard) while GNU make 4 doesn't.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shinh @hooneygogo