Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

Use sha256 for commitments #1027

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Use sha256 for commitments #1027

merged 1 commit into from
Aug 16, 2018

Conversation

jtoohill
Copy link
Contributor

No description provided.

@jtoohill jtoohill requested a review from gdbelvin August 15, 2018 21:30
@codecov
Copy link

codecov bot commented Aug 15, 2018

Codecov Report

Merging #1027 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1027   +/-   ##
=======================================
  Coverage   66.01%   66.01%           
=======================================
  Files          39       39           
  Lines        2742     2742           
=======================================
  Hits         1810     1810           
  Misses        613      613           
  Partials      319      319
Impacted Files Coverage Δ
core/crypto/commitments/commitments.go 90% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4467f44...8b3283c. Read the comment docs.

@gdbelvin gdbelvin merged commit e6d1b76 into master Aug 16, 2018
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Aug 17, 2018
* master:
  Use sha256 for commitments (google#1027)
  Fix vet error (google#1025)
@jtoohill jtoohill deleted the commit-sha256 branch August 22, 2018 17:55
jtoohill pushed a commit to jtoohill/trillian that referenced this pull request Aug 29, 2018
Key Transparency would like to support SHA256 as well, see e.g. google/keytransparency#1027
gdbelvin pushed a commit to google/trillian that referenced this pull request Aug 31, 2018
Key Transparency would like to support SHA256 as well, see e.g. google/keytransparency#1027
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants