Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

Remove Ambiguous types.User.DirectoryId #1154

Merged
merged 7 commits into from Jan 14, 2019
Merged

Conversation

gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Jan 7, 2019

The DirectoryId in User is ambiguous because it is already implicitly defined by the public key of the directory, resulting in numerous checks to verify that these two values are in sync.

@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #1154 into master will decrease coverage by 0.52%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1154      +/-   ##
==========================================
- Coverage    65.1%   64.58%   -0.53%     
==========================================
  Files          41       41              
  Lines        3112     3103       -9     
==========================================
- Hits         2026     2004      -22     
- Misses        751      757       +6     
- Partials      335      342       +7
Impacted Files Coverage Δ
core/integration/monitor_tests.go 74.62% <ø> (-1.09%) ⬇️
core/integration/client_tests.go 85.89% <ø> (-0.24%) ⬇️
core/client/client.go 66.03% <100%> (+0.82%) ⬆️
core/client/batch_client.go 62.26% <100%> (ø) ⬆️
core/client/get_and_verify.go 55.12% <50%> (ø) ⬆️
core/client/batch_get_and_verify.go 70.58% <75%> (ø) ⬆️
core/sequencer/trillian_client.go 56.36% <0%> (-5.46%) ⬇️
impl/sql/mutationstorage/mutations.go 68.42% <0%> (-5.27%) ⬇️
core/sequencer/server.go 68.97% <0%> (-3.27%) ⬇️
impl/sql/directory/storage.go 70.47% <0%> (-1.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89d0df8...c22f172. Read the comment docs.

* master:
  Update API Documentation (google#1160)
  Lazy load key material (google#1161)
  Fix linter backlog (google#1151)
  Allow batch size to be configurable (google#1147)
@gdbelvin gdbelvin merged commit 0b080c5 into google:master Jan 14, 2019
@gdbelvin gdbelvin deleted the user branch January 14, 2019 23:36
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jan 23, 2019
* master: (31 commits)
  Fix CI (google#1164)
  Trim trillian.Tree (google#1165)
  Use golangci-lint (google#1166)
  Nits (google#1163)
  Revert "Trim Directory info (google#1157)" (google#1162)
  Trim Directory info (google#1157)
  Remove Ambiguous types.User.DirectoryId (google#1154)
  Update API Documentation (google#1160)
  Lazy load key material (google#1161)
  Fix linter backlog (google#1151)
  Allow batch size to be configurable (google#1147)
  Frontend implementation (google#1153)
  Nonblocking PublishRevisions (google#1149)
  Follow google/trillian#1385 (google#1150)
  Submit SequencedLeaves with Batch API  (google#1148)
  Change (low,high] to [low,high) intervals in HighWatarmarks (google#1144)
  Write to Trillian Map At Revision (google#1146)
  Better sequencer logging  (google#1145)
  Enforce one trillian Map caller at a time with sequencer election (google#1009)
  Client: BatchCreateMutation (google#1142)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants