Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledgements #1490

Merged
merged 3 commits into from Mar 9, 2020
Merged

Acknowledgements #1490

merged 3 commits into from Mar 9, 2020

Conversation

@gdbelvin
Copy link
Collaborator

gdbelvin commented Mar 6, 2020

No description provided.

gdbelvin added 2 commits Mar 6, 2020
@gdbelvin gdbelvin requested a review from google/keytransparency as a code owner Mar 6, 2020
@gdbelvin gdbelvin requested a review from taknira Mar 6, 2020
@googlebot googlebot added the cla: yes label Mar 6, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #1490 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1490      +/-   ##
==========================================
- Coverage   68.05%   68.03%   -0.03%     
==========================================
  Files          54       54              
  Lines        4026     4026              
==========================================
- Hits         2740     2739       -1     
- Misses        884      888       +4     
+ Partials      402      399       -3
Impacted Files Coverage Δ
core/sequencer/election/tracker.go 70.11% <0%> (-10.35%) ⬇️
core/sequencer/server.go 73.94% <0%> (+0.97%) ⬆️
impl/sql/directory/storage.go 69.17% <0%> (+1.5%) ⬆️
core/keyserver/revisions.go 64.62% <0%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6ef70f...13f1e2b. Read the comment docs.

@gdbelvin gdbelvin requested review from Mercurrent and removed request for taknira Mar 6, 2020
@gdbelvin gdbelvin merged commit 3bb1289 into google:master Mar 9, 2020
6 checks passed
6 checks passed
LGTM analysis: Go No code changes detected
Details
GolangCI No issues found!
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing c6ef70f...13f1e2b
Details
codecov/project Absolute coverage decreased by -0.03, only covered lines were removed
Details
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Mar 9, 2020
* master:
  Acknowledgements (google#1490)
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Mar 25, 2020
* master: (109 commits)
  Upgrade Prometheus (google#1500)
  Run `go build ./...` with github action (google#1446)
  Replace tinkio.ProtoFile with keyset.BinaryReader (google#1492)
  Bump github.com/golang/mock from 1.4.1 to 1.4.2
  Bump github.com/prometheus/client_golang from 1.5.0 to 1.5.1
  Bump github.com/golang/protobuf from 1.3.3 to 1.3.5
  Bump github.com/google/tink from 1.3.0-rc4 to 1.3.0
  New Design Doc (google#1469)
  Acknowledgements (google#1490)
  Use cases (google#1489)
  Bump github.com/prometheus/client_golang from 1.4.1 to 1.5.0 (google#1486)
  README.md # Related (google#1485)
  Explain authorized keys (google#1484)
  Use new prometheus sidecar deployment (google#1483)
  don't overwrite the ReplicaSet service label (google#1482)
  Update encrypted creds (google#1481)
  Pickup DB_HOST env variable (google#1480)
  Fix credential encryption (google#1479)
  Use Cloud MySQL in GKE (google#1473)
  Update client_secrets.json.enc (google#1478)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.