Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

Simplify command line client flags #738

Merged
merged 6 commits into from Aug 12, 2017
Merged

Conversation

gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Aug 9, 2017

With the transition onto Trillian, several of the previous flags are now obsolete.
This PR cleans up and clarifies command line flags.  

This PR also fixes a few things in the client and cleans up docker-compose.

References:
#712
Closes #659

@codecov-io
Copy link

codecov-io commented Aug 9, 2017

Codecov Report

Merging #738 into master will increase coverage by 0.04%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #738      +/-   ##
=========================================
+ Coverage   48.66%   48.7%   +0.04%     
=========================================
  Files          30      30              
  Lines        2503    2505       +2     
=========================================
+ Hits         1218    1220       +2     
  Misses       1088    1088              
  Partials      197     197
Impacted Files Coverage Δ
integration/testutil.go 68.88% <100%> (ø) ⬆️
core/client/kt/verify.go 52.63% <80%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c459b76...f5ee1f9. Read the comment docs.

@gdbelvin gdbelvin changed the title WIP: Simplify Flags Simplify command line client flags Aug 10, 2017
@gdbelvin gdbelvin removed the WIP label Aug 10, 2017
@gdbelvin gdbelvin requested a review from liamsi August 10, 2017 22:38
Copy link
Contributor

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides a few nits:

  • there seems to be copy&paste error in the prepare_client.sh script
  • maybe delete the provided yaml file (?)

KTURL="${KTURLDEFAULT}"
read -p "Trillian Map verification key: " MAPKEY
if [[ -n "${MAPKEY}" ]]; then
printf "map-key: %s\n" "${LOGKEY}" >> .keytransparency.yaml
Copy link
Contributor

@liamsi liamsi Aug 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to ${MAPKEY}?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

kt-url: "35.184.134.53:8080"
client-secret: "client_secret.json"
service-key: ""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this new line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


kt-url: localhost:8080
client-secret:
service-key:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file looks like it does not work as it is. Also, and it gets completely overwritten below (in prepare_client.sh).
Is it still useful? Or should we delete it completely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This empty file allows the command line client to use the defaults specified in its command line flags, which do work - and it removes another place where we need to manage defaults.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. LGTM

@gdbelvin
Copy link
Contributor Author

Updated PTAL

liamsi
liamsi approved these changes Aug 12, 2017
@liamsi liamsi merged commit bb9607e into google:master Aug 12, 2017
@gdbelvin gdbelvin deleted the polish/flags branch August 14, 2017 19:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prepare_client.sh is out of date
3 participants