Simplify command line client flags #738
Conversation
Codecov Report
@@ Coverage Diff @@
## master #738 +/- ##
=========================================
+ Coverage 48.66% 48.7% +0.04%
=========================================
Files 30 30
Lines 2503 2505 +2
=========================================
+ Hits 1218 1220 +2
Misses 1088 1088
Partials 197 197
Continue to review full report at Codecov.
|
scripts/prepare_client.sh
Outdated
| KTURL="${KTURLDEFAULT}" | ||
| read -p "Trillian Map verification key: " MAPKEY | ||
| if [[ -n "${MAPKEY}" ]]; then | ||
| printf "map-key: %s\n" "${LOGKEY}" >> .keytransparency.yaml |
.keytransparency.yaml
Outdated
| kt-url: "35.184.134.53:8080" | ||
| client-secret: "client_secret.json" | ||
| service-key: "" | ||
|
|
.keytransparency.yaml
Outdated
|
|
||
| kt-url: localhost:8080 | ||
| client-secret: | ||
| service-key: |
There was a problem hiding this comment.
This file looks like it does not work as it is. Also, and it gets completely overwritten below (in prepare_client.sh).
Is it still useful? Or should we delete it completely?
There was a problem hiding this comment.
This empty file allows the command line client to use the defaults specified in its command line flags, which do work - and it removes another place where we need to manage defaults.
There was a problem hiding this comment.
Thanks for the explanation. LGTM
|
Updated PTAL |
With the transition onto Trillian, several of the previous flags are now obsolete.
This PR cleans up and clarifies command line flags.
This PR also fixes a few things in the client and cleans up docker-compose.
References:
#712
Closes #659