This repository has been archived by the owner on Jul 16, 2021. It is now read-only.
Hackathon: monitor page #804
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monitor service and types: regenerate protos and downgrade grpc-gateway to match trillian's Monitor service and types: regenerate protos and downgrade grpc-gateway to match trillian's work in progress addressed some early review comments
simplify monitor Dockerfile (non-opinionated) add argument to 'prepare script' such that the monitor can contact the kt-server if it isn't reachable via localhost add proto messages that proof certain errors occurred early review comments add signing capability move verification into separate function gofmt golint / presubmit.sh regenerate proto with correct dependency versions add script for generating monitor signing key Add comments to exported methods Add "observed at" timestamp, sign the root hash update test
Minor changes verify signature on response resolves google#672 Add log sig verification rebase wip WIP add TODO remove streaming API (simplifies moving to core) Monitor service and types: regenerate protos and downgrade grpc-gateway to match trillian's Monitor service and types: regenerate protos and downgrade grpc-gateway to match trillian's work in progress revert local changes, add TODOs simplify monitor Dockerfile (non-opinionated)
Minor changes verify signature on response resolves google#672 Add log sig verification rebase wip WIP add TODO remove streaming API (simplifies moving to core) Monitor service and types: regenerate protos and downgrade grpc-gateway to match trillian's Monitor service and types: regenerate protos and downgrade grpc-gateway to match trillian's work in progress revert local changes, add TODOs simplify monitor Dockerfile (non-opinionated) regenerate proto with correct dependency versions Add to kubernetes config and deploy script resolves google#672 rebase rebase =gofmt WIP
* move monitor service types into separate file * move verification (wip) into sperate file * generate and use separate priv. key for signing * pass pointer of priv key * unexport verifKeys
* Remove replacer which isn't used anywhere
# Conflicts: # core/client/kt/requests.go # core/mutator/entry/entry.go # core/mutator/entry/entry_test.go # impl/proto/monitor_v1_service/gen.go
# Conflicts: # docker-compose.yml
…on_verifying_monitor
# Conflicts: # core/monitor/monitor.go # core/monitor/verify.go # impl/monitor/monitor_test.go # impl/monitor/server.go
liamsi
force-pushed
the
hackathon_monitor_Page
branch
from
068857c
to
5d2a8a2
Compare
liamsi
force-pushed
the
hackathon_monitor_Page
branch
from
5d2a8a2
to
d25aa7e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very first crack on #803
Status: Code needs a lot of cleanup, rebasing on master, and some CSS to make it look more appealing.
Currently the page looks like this: