Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish a ko builder with GCB's kubectl magic #4

Closed
mattmoor opened this issue Feb 5, 2019 · 10 comments
Closed

Publish a ko builder with GCB's kubectl magic #4

mattmoor opened this issue Feb 5, 2019 · 10 comments

Comments

@mattmoor
Copy link
Collaborator

mattmoor commented Feb 5, 2019

Basically this, but ko: https://github.com/GoogleCloudPlatform/cloud-builders/blob/master/kubectl/kubectl.bash

cc @imjasonh

@imjasonh
Copy link
Member

imjasonh commented Feb 5, 2019

Unless we support Go modules (#269) this is going to be gross, along the lines of the go builder, which ln -ses /workspace to a location that it then specifies as $GOPATH. If we support/require Go modules we can build the ko builder with ko, based on an image that has kubectl installed.

The kubectl image is also pretty thoroughly tied to GKE, and it's huge because it installs all of gcloud basically just for auth and so it can call gcloud container clusters get-credentials -- I think we can do better.

@mattmoor
Copy link
Collaborator Author

mattmoor commented Feb 5, 2019

Hmm, that issuing is using Go modules here. I thought Go modules worked with ko, but were slower because of IsSupportedReference going from O(1) to O(something more than 1)?

I'll play around with them on my kodemo repo...

@jonjohnsonjr
Copy link
Collaborator

The naive change to support go modules makes IsSupportedReference ~O(number of files on filesystem) if I understand correctly. We can try populating an index with the packages package to get around that...

@mattmoor
Copy link
Collaborator Author

mattmoor commented Feb 5, 2019

Yeah, Go modules definitely work, but we should look at speeding up IsSupportedReference.

@mattmoor
Copy link
Collaborator Author

mattmoor commented Feb 5, 2019

Hmm, watch isn't working for some reason.

@mattmoor
Copy link
Collaborator Author

mattmoor commented Feb 5, 2019

Ok, I know what the issue is, it's my hack for determining the enclosing package when we see things change, hopefully nbd.

@mattmoor
Copy link
Collaborator Author

mattmoor commented Feb 5, 2019

FYI: google/go-containerregistry#359

@jonjohnsonjr jonjohnsonjr transferred this issue from google/go-containerregistry Mar 21, 2019
@jonjohnsonjr
Copy link
Collaborator

@imjasonh what does this have to do with go modules? Is this still relevant?

@imjasonh
Copy link
Member

imjasonh commented Oct 23, 2019 via email

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

karthikraobr pushed a commit to karthikraobr/ko that referenced this issue Feb 15, 2023
fix curl modes to point to new repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants