Validate KO_CONFIG_PATH #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcnghia
changed the title
Codecov Report
@@ Coverage Diff @@
## main #471 +/- ##
==========================================
+ Coverage 48.58% 48.87% +0.29%
==========================================
Files 43 43
Lines 2221 2230 +9
==========================================
+ Hits 1079 1090 +11
+ Misses 956 955 -1
+ Partials 186 185 -1
Continue to review full report at Codecov.
|
|
This change will break users that had their KO_CONFIG_PATH ignored previously. |
imjasonh
approved these changes
Oct 11, 2021
|
@imjasonh can you please help merge after I fix the conflict? thanks |
imjasonh
previously approved these changes
Oct 27, 2021
|
More conflicts :) one more rebase? |
Closed
tcnghia
force-pushed
the
validate-config-path
branch
from
830599f
to
872411c
Compare
imjasonh
previously approved these changes
Feb 8, 2022
|
@imjasonh I don't have merge permission so you'll have to merge it before we run into conflicts :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids surprises when:
.ko.yamlin their KO_CONFIG_PATH (i.e. pointing to a file)