Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nullability for java sources ignores annotations #167

Closed
yigit opened this issue Nov 24, 2020 · 0 comments · Fixed by #1116
Closed

nullability for java sources ignores annotations #167

yigit opened this issue Nov 24, 2020 · 0 comments · Fixed by #1116
Assignees
@neetopia
Labels
P1 major features or blocking bugs
Milestone
1.0.7

Comments

@yigit
Copy link
Collaborator

yigit commented Nov 24, 2020

Given a java input like this:

class Foo {
    @NonNull
    public static List<String> nonNullAnnotated;
}

The nullability of nonNullAnnotated is returned as platform instead of not null. Given that kotlin compiler already reads these, i think KSP should be consistent and also look for those annotations as well.
@neetopia neetopia self-assigned this Nov 24, 2020
@neetopia neetopia added the enhancement New feature or request label Nov 24, 2020
@yigit yigit mentioned this issue Nov 28, 2020
Open
@ting-yuan ting-yuan added the P2 affects usability but not blocks users label Dec 9, 2020
@ting-yuan ting-yuan added this to the 2021Q1 milestone Dec 31, 2020
@ting-yuan ting-yuan modified the milestones: 1.0.0-beta, 1.0.0 Mar 22, 2021
@ting-yuan ting-yuan modified the milestones: 1.0.0, 1.0.7 Sep 21, 2022
@ting-yuan ting-yuan added P1 major features or blocking bugs and removed enhancement New feature or request P2 affects usability but not blocks users labels Sep 21, 2022
neetopia added a commit to neetopia/ksp that referenced this issue Sep 22, 2022
@neetopia
respect nullability annotations on Java type references.
a7c25dc 
* for referenced java types, compiler already handles nullability annotations.
* fixes google#167
@neetopia neetopia mentioned this issue Sep 22, 2022
Merged
neetopia added a commit to neetopia/ksp that referenced this issue Sep 23, 2022
@neetopia
respect nullability annotations on Java type references.
3426f25 
* for referenced java types, compiler already handles nullability annotations.
* fixes google#167
neetopia added a commit that referenced this issue Sep 23, 2022
@neetopia
respect nullability annotations on Java type references.
cfdf696 
* for referenced java types, compiler already handles nullability annotations.
* fixes #167
github-actions bot pushed a commit that referenced this issue Sep 23, 2022
@neetopia
respect nullability annotations on Java type references.
c944449 
* for referenced java types, compiler already handles nullability annotations.
* fixes #167

(cherry picked from commit cfdf696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neetopia neetopia

Labels
P1 major features or blocking bugs
Projects
None yet
Milestone
1.0.7
Development

Successfully merging a pull request may close this issue.

respect nullability annotations on Java type references. neetopia/ksp
3 participants
@yigit @ting-yuan @neetopia