Add go.mod file based on current WORKSPACE #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file defines kythe.io/ as the root of a Go 1.11 module requiring the given imports. When using a `go` tool that includes support for modules (currently the tool must be built from HEAD), Kythe's Go code will now be built and tested with the same dependency versions as `bazel test` uses. Note: the `go.mod` file must currently be kept in sync with our WORKSPACE file manually
schroederc
requested review from
creachadair and
salguarnieri
and removed request for
creachadair
|
No, there's an ongoing issue: #2834 |
salguarnieri
approved these changes
Jul 16, 2018
schroederc
added a commit
to schroederc/kythe
that referenced
this pull request
Nov 8, 2018
This file defines kythe.io/ as the root of a Go 1.11 module requiring the given imports. When using a `go` tool that includes support for modules (currently the tool must be built from HEAD), Kythe's Go code will now be built and tested with the same dependency versions as `bazel test` uses. Note: the `go.mod` file must currently be kept in sync with our WORKSPACE file manually
schroederc
added a commit
to schroederc/kythe
that referenced
this pull request
Nov 8, 2018
This file defines kythe.io/ as the root of a Go 1.11 module requiring the given imports. When using a `go` tool that includes support for modules (currently the tool must be built from HEAD), Kythe's Go code will now be built and tested with the same dependency versions as `bazel test` uses. Note: the `go.mod` file must currently be kept in sync with our WORKSPACE file manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file defines kythe.io/ as the root of a Go 1.11 module requiring
the given imports. When using a
gotool that includes support formodules (currently the tool must be built from HEAD), Kythe's Go code
will now be built and tested with the same dependency versions as
bazel testuses.Note: the
go.modfile must currently be kept in sync with ourWORKSPACE file manually