IdentifierConverter

[odashi]

Overview

Introduces a common processing for all identifiers.

Details

This change introduces IdentifierConverter, which converts identifier strings into:

• foo --> \foo, if use_math_symbols == True and the given identifier matches a supported math symbol name.
• x --> x, if the given identifier is exactly 1 character (except _)
• foo_bar --> \mathrm{foo\_bar}, otherwise.

This change also removes use_raw_function_name flag: the rule is applied to all identifiers (not only function names) without exceptions.

IdentifierConverter also returns a boolean flag to express whether the returned expression can be treated as a single character or not. This is potentially used to fix #89 .

References

• Fixes Fine-grained name processing #82

Blocked by

• NA

[ShigekiKarita]

FYI sympy seems to use \text instead of \mathrm for identifiers (but not always 🤔) https://github.com/sympy/sympy/blob/8ad4f490fecc269eac69a6976b50f44396f6a1ad/sympy/printing/tests/test_latex.py#L2203
sympy/sympy#15934

[odashi]

@ShigekiKarita I think \text is used for rendering regular texts with the default font (not constraining it to Roman). In our case, I think always using \mathrm would be better, though I'm not sure how they chose both commands.