Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a switch for processing function names #35

Merged
merged 2 commits into from Oct 4, 2022

Conversation

1MLightyears
Copy link
Contributor

fix #31 .
A few descriptions of this change:

  • add a parameter self.raw_func_name. If it's False, treat all underlines in function name as label of subscript (output f_n as fn); otherwise treat underline as part of function name (output f_n as f_n).
    defined in LatexifyVisitor.__init__(), default is False to keep consistency with default behaviors in previous editions.
  • As a result, change arguments of with_latex, get_latex, etc. to (*args,**kwargs) for future use (and they are already used this time). Might be more and more parameters for decorators, I think collect and process them all at LatexifyVisitor.__init__() is a kind of makeshift...

@google-cla
Copy link

google-cla bot commented Dec 6, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@1MLightyears
Copy link
Contributor Author

@googlebot I signed it!

Copy link
Collaborator

@odashi odashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@odashi odashi merged commit cfa3508 into google:develop Oct 4, 2022
@1MLightyears
Copy link
Contributor Author

Thanks!

OMG That was a PR 2 yrs ago 😲
It's great to see still working on this anyway. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Underscores in function names conflict with LaTeX and shown as subscripts
2 participants