math_symbol kwarg #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odashi
requested changes
Jul 27, 2020
odashi
approved these changes
Jul 27, 2020
ryxcommar
force-pushed
the
develop_math_symbol
branch
from
d53576e
to
71f3d2d
Compare
|
Sorry about that. Fixed, and double checked that tests pass. |
|
Great work, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: issue #6
math_symbolkwargNew behaviors:
Old functions remain the same, so long as variable names are not in the
greek_and_hebrewlist.Fixes to
setup.pyMoving from a module structure to a package structure,
py_modules=['latexify']no longer works. So I replaced it withpackages=find_packages().Additionally, I tested that
<=3.8does not work as intended. (Technically, I tested that<=3.7does not work, as I am on python 3.7). I am using<3.9now instead, which should work.