Skip to content

Commit

Permalink
Add CMake build support.
Browse files Browse the repository at this point in the history
Fixes #466

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=189425354
  • Loading branch information
pwnall committed Mar 17, 2018
1 parent 0fa5a4f commit 739c251
Show file tree
Hide file tree
Showing 8 changed files with 493 additions and 47 deletions.
17 changes: 16 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ os:
- linux
- osx

env:
- BUILD_TYPE=Debug
- BUILD_TYPE=RelWithDebInfo

addons:
apt:
# List of whitelisted in travis packages for ubuntu-trusty can be found here:
Expand All @@ -23,6 +27,7 @@ addons:
- ubuntu-toolchain-r-test
- llvm-toolchain-trusty-5.0
packages:
- cmake
- gcc-7
- g++-7
- clang-5.0
Expand All @@ -49,6 +54,16 @@ install:
- echo ${CC}
- echo ${CXX}
- ${CXX} --version
- cmake --version

before_script:
- mkdir -p build && cd build
- cmake .. -DCMAKE_BUILD_TYPE=$BUILD_TYPE
- cmake --build .
- cd ..

script:
- make -j 4 check
- cd build ; ctest --verbose ; cd ..
- "if [ -f build/db_bench ] ; then build/db_bench ; fi"
- "if [ -f build/db_bench_sqlite3 ] ; then build/db_bench_sqlite3 ; fi"
- "if [ -f build/db_bench_tree_db ] ; then build/db_bench_tree_db ; fi"
Loading

4 comments on commit 739c251

@jakirkham
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any thoughts on making a release with this change included?

@perone
Copy link

@perone perone commented on 739c251 Nov 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on that, a release with these changes would be very useful.

@pwnall
Copy link
Member Author

@pwnall pwnall commented on 739c251 Nov 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're landing a fair amount of breaking changes, and I'd like to have one release that has all of them. This way, package maintainers will need to do some non-trivial work to get on 1.21, but will get back to smooth sailing from there on.

@perone
Copy link

@perone perone commented on 739c251 Nov 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for the feedback.

Please sign in to comment.