Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up compile-time warnings (gcc 7.1) #492

Closed
wants to merge 1 commit into from
Closed

Clean up compile-time warnings (gcc 7.1) #492

wants to merge 1 commit into from

Conversation

maflcko
Copy link
Contributor

@maflcko maflcko commented Jul 30, 2017

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@maflcko maflcko mentioned this pull request Jul 31, 2017
Merged
@TheBlueMatt
Copy link

I think the CLA bot is just broken - I've got the email used in git in my google account and had signed the CLA long ago. I'm not gonna create a new google account with that email just to sign the CLA.

@googlebot
Copy link

CLAs look good, thanks!

Clean up compile-time warnings (gcc 7.1)
7595439 
* max_file_size was already a size_t, so return that.

(cherry picked from commit 0ec2a34 by TheBlueMatt)
This was referenced Mar 19, 2018
Closed
Closed
@maflcko
Copy link
Contributor Author

maflcko commented Apr 12, 2018

@pwnall This seems to be commonly reported (#558, #459). Any chance at taking a look?

@pwnall
Copy link
Member

pwnall commented Apr 12, 2018

@MarcoFalke Sorry, I should've documented my thoughts.

I looked at this earlier. It definitely looks like a good step forward, but I haven't been able to find the time to test it properly. Specifically, ConsumeDecimalNumber in util/logging.cc has ran into compiler bugs (or UB?) before, so I'd need to repro the crashiness fixed by 09a3c8e and make sure this code change doesn't reintroduce it.

@pwnall
Copy link
Member

pwnall commented Apr 14, 2018

a0008de took care of ConsumeDecimalNumber. The other 2 fixes LGTM. I'll get them through our internal repository.

Thank you for your contribution!

@pwnall pwnall requested review from pwnall and removed request for pwnall April 14, 2018 15:08
@pwnall pwnall self-assigned this Apr 14, 2018
pwnall added a commit to pwnall/leveldb that referenced this pull request Apr 14, 2018
@pwnall
Test merge commit for PR google#492.
9aa7dfe
pwnall pushed a commit that referenced this pull request Apr 17, 2018
@pwnall
Fix sign mismatch warnings in GCC.
14cce84 
This was contributed in #492

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=193080913
@pwnall
Copy link
Member

pwnall commented Apr 17, 2018

This PR landed as commit 14cce84. Thank you for your contribution!

@pwnall pwnall closed this Apr 17, 2018
@maflcko maflcko deleted the Mf1707-leveldbCherryPickGccWarnings branch April 17, 2018 03:05
maochongxin pushed a commit to maochongxin/leveldb that referenced this pull request Jul 21, 2022
@pwnall @dominichamon
Add GCC on OSX to list of Travis CI configurations. (google#492)
0bbaeea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pwnall pwnall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maflcko @googlebot @TheBlueMatt @pwnall