handle error of OCSP_sendreq_nbio #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banaag
approved these changes
Feb 12, 2021
twifkak
reviewed
Feb 17, 2021
| break; | ||
| switch (OCSP_sendreq_nbio(dst, octx) { | ||
| case -1: | ||
| continue; |
There was a problem hiding this comment.
Can you add a sleep with exponential backoff and a limit to the number of retries? I'm worried about an edge case that pegs the CPU or hammers the OCSP responder. (See item 5 at https://gist.github.com/sleevi/5efe9ef98961ecfb4da8.)
There was a problem hiding this comment.
I filed #82 to track this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as document says,
OCSP_sendreq_nbioreturns 3 values.Then this logic should handle error returned value to propagate the context to the return value.