Add primes example #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWoloszyn
reviewed
Sep 9, 2019
examples/primes.cpp
Outdated
|
|
||
| // isPrime returns true if i is prime. | ||
| bool isPrime(int i) { | ||
| for (int j = 2; j < i; j++) { |
There was a problem hiding this comment.
I know this is simply example code, and efficiency is not actually your goal, but my brain would much prefer at least j < sqrt(i). I would not hold this back, as its not the point of the example, and for the same performance you would need a much larger searchMax.
There was a problem hiding this comment.
Done. I was on the fence about this, and you've pushed me over.
AWoloszyn
approved these changes
Sep 9, 2019
Demonstrates the use of marl::Ticket::Queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrates the use of
marl::Ticket::Queue.