Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Device orientation demo for iOS #319

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

MobeenAshraf
Copy link
Contributor

@MobeenAshraf MobeenAshraf commented May 30, 2020

Closes #295

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@MobeenAshraf MobeenAshraf force-pushed the Fix-Device-Orientation-For-IOS branch from 031e848 to dc5cf36 Compare May 30, 2020 21:33
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@tjgq tjgq merged commit 831fc97 into google:master Jul 2, 2020
@campmdabt
Copy link

campmdabt commented Jul 3, 2020

Does this fix also address the issues presented in iOS 13.4 as outlined in this forum post, or is that altogether a different problem? https://krpano.com/forum/wbb/index.php?page=Thread&threadID=17424

To quote:

The gyro and VR controls [in krpano] are using the browsers 'devicemotion' event (by default) to get information about the current device rotation state. And in iOS 13.4 that event no longer reports the gyroscope rotation information, only the acceleration information are available. That makes the gyro/VR control working strangely slow and inaccurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gyro example not working on iOS 13.x due to newly introduced permission control
4 participants