Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Stage#updateSize() to setSize() and pass in an explicit size. #36

Merged
merged 1 commit into from
Sep 19, 2016

Conversation

tjgq
Copy link
Collaborator

@tjgq tjgq commented Sep 9, 2016

Passing in an explicit size enables the off-page rendering use case,
where the dimensions of the stage's underlying element can't be obtained
from the DOM. For regular clients, Viewer#updateSize() takes care of
getting the dimensions from the DOM and passing them into the stage on
the window resize handler.

Also clean up the ancilliary size update logic for the Css and Flash
stages. An explicit pixel size was being set on the DOM element, but this
is not required since the constructor sets its dimensions relative to the
parent element.

Passing in an explicit size enables the off-page rendering use case,
where the dimensions of the stage's underlying element can't be obtained
from the DOM. For regular clients, Viewer#updateSize() takes care of
getting the dimensions from the DOM and passing them into the stage on
the window resize handler.

Also clean up the ancilliary size update logic for the Css and Flash
stages. An explicit pixel size was being set on the DOM element, but this
is not required since the constructor sets its dimensions relative to the
parent element.
@tjgq tjgq merged commit d14556b into google:master Sep 19, 2016
@tjgq tjgq deleted the stage-size branch September 19, 2016 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant