Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update demo screenshots #680

Closed
wants to merge 1 commit into from

Conversation

richard-to
Copy link
Collaborator

Noticed that we were missing some screenshots on the demo site.

@wwwillchen
Copy link
Collaborator

I've noticed this too, that we're not really remembering to re-gen screenshots. Also, I think the screenshots will be slightly different depending on the platform (Mac vs. Windows vs. Linux) so it'll create a lot of diffs when different contributors create them.

I'm thinking whether we should just generate the screenshots right before pushing a new demo. The only trick is that it might be a bit more difficult to run this on our work machines. WDYT?

@richard-to
Copy link
Collaborator Author

I've noticed this too, that we're not really remembering to re-gen screenshots. Also, I think the screenshots will be slightly different depending on the platform (Mac vs. Windows vs. Linux) so it'll create a lot of diffs when different contributors create them.

I'm thinking whether we should just generate the screenshots right before pushing a new demo. The only trick is that it might be a bit more difficult to run this on our work machines. WDYT?

Yeah it does seem like the steps to generate the screenshots are easy to automate via Github actions or something. Yes, my work machine is unfortunately pretty borked for running Mesop (need to fix that at some point...).

I do wonder if we could host the demo site on Hugging Face (would just need something to keep the Space from sleeping though)

@wwwillchen
Copy link
Collaborator

I've noticed this too, that we're not really remembering to re-gen screenshots. Also, I think the screenshots will be slightly different depending on the platform (Mac vs. Windows vs. Linux) so it'll create a lot of diffs when different contributors create them.
I'm thinking whether we should just generate the screenshots right before pushing a new demo. The only trick is that it might be a bit more difficult to run this on our work machines. WDYT?

Yeah it does seem like the steps to generate the screenshots are easy to automate via Github actions or something. Yes, my work machine is unfortunately pretty borked for running Mesop (need to fix that at some point...).

I do wonder if we could host the demo site on Hugging Face (would just need something to keep the Space from sleeping though)

yeah, I think hosting on hugging face isn't a bad idea - let me give it a try. I think we have enough traffic that it wouldn't sleep.

@wwwillchen
Copy link
Collaborator

Just opened #684 - I think we can close this.

@wwwillchen wwwillchen closed this Jul 29, 2024
@richard-to richard-to deleted the update-demo-screenshots branch August 4, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants