Don't mutate BaseTestClass.record_data() argument. (#856)

google · Dec 7, 2022 · 9238569 · 9238569
1 parent f788d41
commit 9238569
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/mobly/base_test.py b/mobly/base_test.py
@@ -660,6 +660,7 @@ def record_data(self, content):
       content: dict, the data to add to summary file.
     """
     if 'timestamp' not in content:
+      content = content.copy()
       content['timestamp'] = utils.get_current_epoch_time()
     self.summary_writer.dump(content, records.TestSummaryEntryType.USER_DATA)
 

diff --git a/tests/mobly/base_test_test.py b/tests/mobly/base_test_test.py
@@ -2198,6 +2198,7 @@ def logic(self, a, b):
 
   def test_write_user_data(self):
     content = {'a': 1}
+    original_content = content.copy()
 
     class MockBaseTest(base_test.BaseTestClass):
 
@@ -2215,7 +2216,9 @@ def test_something(self):
           continue
         hit = True
         self.assertEqual(c['a'], content['a'])
+        self.assertIn('timestamp', c)
         self.assertIsNotNone(c['timestamp'])
+        self.assertEqual(content, original_content, 'Content arg was mutated.')
     self.assertTrue(hit)
 
   def test_record_controller_info(self):