Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repeat parent for better repeat representation. #885

Closed
wants to merge 1 commit into from

Conversation

booneng
Copy link
Collaborator

@booneng booneng commented May 5, 2023

This will remove the ambiguity for test case names with repeat suffix.


This change is Reviewable

@booneng booneng requested a review from xpconanfan May 5, 2023 09:54
@booneng booneng self-assigned this May 5, 2023
for i in range(repeat_count):
new_test_name = f'{test_name}_{i}'
record = self.exec_one_test(new_test_name, test_method)
if previous_record is not None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the previous_record always None here?

@xpconanfan
Copy link
Collaborator

Closing as this was fixed in #905

@xpconanfan xpconanfan closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants