Add parent field to records to represent repeat and retry information. #905
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @booneng and @xpconanfan)
mobly/base_test.py line 720 at r1 (raw file):
Previously, xpconanfan (Ang Li) wrote…
Trying to discuss here.
Should we still generate new names, now that the record clearly marks the sequence.
I guess it's easy for humans to understand.
Does the downstream result process also try to add the postfixes?
MH adds their own suffix but we are trying to fix that. Otherwise, no other process adds suffixes. I think we should remove it in another change because other processes read the suffixes to determine the repeat/retry number.
mobly/records.py line 328 at r1 (raw file):
Previously, xpconanfan (Ang Li) wrote…
mark this as deprecate?
Done.
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @booneng)
mobly/records.py line 328 at r1 (raw file):
Previously, booneng (boon) wrote…
Done.
should probably mention it's deprecated at the very beginning of the sentence, like [DEPRECATED] Use ... instead. before the sentence starts.
or is there an official way of marking deprecation in sphinx, our doc generator?
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @booneng and @xpconanfan)
mobly/records.py line 328 at r1 (raw file):
Previously, xpconanfan (Ang Li) wrote…
should probably mention it's deprecated at the very beginning of the sentence, like
[DEPRECATED] Use ... instead.before the sentence starts.
or is there an official way of marking deprecation in sphinx, our doc generator?
Done.
This change is