Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using tcp:0 in adb forward to pick available host port in snippet client #904

Merged
merged 7 commits into from
Dec 15, 2023
Merged

Using tcp:0 in adb forward to pick available host port in snippet client #904

merged 7 commits into from
Dec 15, 2023

Conversation

mhaoli
Copy link
Collaborator

@mhaoli mhaoli commented Dec 14, 2023 •
edited by xpconanfan
Loading

This change is Reviewable

@mhaoli mhaoli mentioned this pull request Dec 14, 2023
Closed
@mhaoli mhaoli self-assigned this Dec 14, 2023
@xpconanfan xpconanfan added this to the Mobly Release 1.12.3 milestone Dec 14, 2023
@xpconanfan
Copy link
Collaborator

Should probably mark utils.get_available_host_port as deprecated
add a warning log and update the docstring to reflect.
can be in a separate CL

@mhaoli
Copy link
Collaborator Author

mhaoli commented Dec 15, 2023

Should probably mark utils.get_available_host_port as deprecated add a warning log and update the docstring to reflect. can be in a separate CL

Sg. And yeah, let's submit this CL and make sure this doesn't break users first :)

@xpconanfan xpconanfan merged commit 6c5d666 into google:master Dec 15, 2023
16 of 17 checks passed
@mhaoli mhaoli mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpconanfan xpconanfan xpconanfan approved these changes

Assignees

@mhaoli mhaoli

Labels
improvement
Projects
None yet
Milestone
Mobly Release 1.12.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mhaoli @xpconanfan