[WIP] Utilize tcp:0 to find available adb port instead of portpicker #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR caused presubmit failed in cl/510984231. Taking a look tomorrow. Marking this as WIP for now. |
mhaoli
changed the title
mhaoli
changed the title
xpconanfan
reviewed
Feb 22, 2023
| By default, the ADB binary supports this feature, i.e. it supports passing 0 | ||
| as host port when doing port forwarding. | ||
|
|
||
| But sometimes users override the `ADB` variable to use a customized variant to |
There was a problem hiding this comment.
can we afford to wait for the migration to adb forwarder to push this PR, or is there some urgency?
There was a problem hiding this comment.
This is not urgent, we can wait for the migration.
mhaoli
changed the title
|
Are we ready to submit this now? |
|
Currently waterfall migration is not completed, waiting until the end of this year, if it is still not completed I will submit the PR. |
|
Now we can do this with simpler code. Closing this and created a new PR #904 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using adb, we can utilize tcp:0 to find available adb port instead of portpicker.
However, when using other ADB alternatives (i.e. waterfall), portpicker is still used, because waterfall forward doesn't print out which port it picked.
This change is