New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use fewer shaders #3045

Merged

elalish merged 1 commit into master from recompile

Dec 11, 2021

Collaborator

elalish commented Dec 11, 2021

While debugging WebXR mode I noticed we were recompiling some shaders that shouldn't. A couple of small fixes:

The placement box is transparent and was double-sided, which was causing it to be rendered twice (with two different shaders).
The shadow is turned off in AR until the model is set on the floor. Turning off the shadow recompiles the shader, so instead I turn it to a small (invisible) value.


          use fewer shaders

d116f9b

elalish self-assigned this

elalish requested review from samaneh-kazemi and a user

December 11, 2021 00:21

ghost approved these changes

View reviewed changes

elalish merged commit b7befad into master

elalish deleted the recompile branch

December 11, 2021 00:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment