Custom prompt #3320
Merged
Custom prompt #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, okay this concept of using synthetic touch events works on Chrome, but not on other browsers - if touch is not supported on a device, they don't let you construct touch events. Looks like I need to switch to PointerEvents first, which I wanted to anyway, but had trouble with last time. I was hoping a synthetic pointer event might trigger a mouse/touch event pair, but alas no. |
|
@diegoteran @samaneh-kazemi Probably one of you will end up implementing Tomi's custom prompts using this API, so I figured you might be interested in how it works. I'll write up a design doc for it too. |
samaneh-kazemi
previously approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to make an API so you can create your own custom interaction prompt, potentially including pan and zoom motions in addition to rotation. It's working here, including an example and docs.