Run steps for all packages, even if previous package failed (#297)

...within the same job Fixes #296 Prepare to release v3.4.4
google · Jan 14, 2021 · af8c428 · af8c428
1 parent 12b6a47
commit af8c428
Show file tree

Hide file tree

Showing 9 changed files with 86 additions and 28 deletions.
diff --git a/.github/workflows/dart.yml b/.github/workflows/dart.yml
@@ -1,4 +1,4 @@
-# Created with package:mono_repo v3.4.3
+# Created with package:mono_repo v3.4.4
 name: Dart CI
 on:
   push:
@@ -33,9 +33,11 @@ jobs:
         with:
           release-channel: dev
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: mono_repo_pub_upgrade
         name: "mono_repo; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: mono_repo
         run: pub upgrade --no-precompile
       - name: "mono_repo; cd ../ && dart mono_repo/bin/mono_repo.dart generate --validate"
@@ -60,9 +62,11 @@ jobs:
         with:
           release-channel: dev
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: mono_repo_pub_upgrade
         name: "mono_repo; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: mono_repo
         run: pub upgrade --no-precompile
       - name: "mono_repo; dartfmt -n --set-exit-if-changed ."
@@ -75,6 +79,7 @@ jobs:
         run: dartanalyzer --fatal-infos .
       - id: test_pkg_pub_upgrade
         name: "test_pkg; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: test_pkg
         run: pub upgrade --no-precompile
       - name: "test_pkg; dartfmt -n --set-exit-if-changed ."
@@ -104,9 +109,11 @@ jobs:
           release-channel: stable
           version: "2.7.0"
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: mono_repo_pub_upgrade
         name: "mono_repo; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: mono_repo
         run: pub upgrade --no-precompile
       - name: mono_repo; dartanalyzer .
@@ -131,9 +138,11 @@ jobs:
         with:
           release-channel: edge
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: test_pkg_pub_upgrade
         name: "test_pkg; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: test_pkg
         run: pub upgrade --no-precompile
       - name: "test_pkg; dartfmt -n --set-exit-if-changed ."
@@ -163,9 +172,11 @@ jobs:
           release-channel: dev
           version: "2.12.0-0.0.dev"
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: test_pkg_pub_upgrade
         name: "test_pkg; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: test_pkg
         run: pub upgrade --no-precompile
       - name: "test_pkg; dartfmt -n --set-exit-if-changed ."
@@ -194,9 +205,11 @@ jobs:
         with:
           release-channel: beta
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: test_pkg_pub_upgrade
         name: "test_pkg; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: test_pkg
         run: pub upgrade --no-precompile
       - name: "test_pkg; dartfmt -n --set-exit-if-changed ."
@@ -226,9 +239,11 @@ jobs:
           release-channel: beta
           version: "2.12.0-29.10.beta"
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: test_pkg_pub_upgrade
         name: "test_pkg; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: test_pkg
         run: pub upgrade --no-precompile
       - name: "test_pkg; dartfmt -n --set-exit-if-changed ."
@@ -257,9 +272,11 @@ jobs:
         with:
           release-channel: stable
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: test_pkg_pub_upgrade
         name: "test_pkg; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: test_pkg
         run: pub upgrade --no-precompile
       - name: "test_pkg; dartfmt -n --set-exit-if-changed ."
@@ -289,9 +306,11 @@ jobs:
           release-channel: stable
           version: "2.10.4"
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: test_pkg_pub_upgrade
         name: "test_pkg; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: test_pkg
         run: pub upgrade --no-precompile
       - name: "test_pkg; dartfmt -n --set-exit-if-changed ."
@@ -321,9 +340,11 @@ jobs:
           release-channel: stable
           version: "2.7.0"
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: mono_repo_pub_upgrade
         name: "mono_repo; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: mono_repo
         run: pub upgrade --no-precompile
       - name: "mono_repo; pub run test -x yaml -P presubmit --test-randomize-ordering-seed=random"
@@ -349,9 +370,11 @@ jobs:
           release-channel: stable
           version: "2.7.0"
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: mono_repo_pub_upgrade
         name: "mono_repo; pub.bat upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: mono_repo
         run: pub.bat upgrade --no-precompile
       - name: "mono_repo; pub run test -x yaml -P presubmit --test-randomize-ordering-seed=random"
@@ -386,9 +409,11 @@ jobs:
         with:
           release-channel: dev
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: mono_repo_pub_upgrade
         name: "mono_repo; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: mono_repo
         run: pub upgrade --no-precompile
       - name: "mono_repo; pub run test -x yaml -P presubmit --test-randomize-ordering-seed=random"
@@ -413,9 +438,11 @@ jobs:
         with:
           release-channel: dev
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: mono_repo_pub_upgrade
         name: "mono_repo; pub.bat upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: mono_repo
         run: pub.bat upgrade --no-precompile
       - name: "mono_repo; pub run test -x yaml -P presubmit --test-randomize-ordering-seed=random"
@@ -451,9 +478,11 @@ jobs:
           release-channel: stable
           version: "2.7.0"
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: mono_repo_pub_upgrade
         name: "mono_repo; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: mono_repo
         run: pub upgrade --no-precompile
       - name: "mono_repo; pub run test -t yaml --test-randomize-ordering-seed=random"
@@ -488,9 +517,11 @@ jobs:
         with:
           release-channel: dev
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: mono_repo_pub_upgrade
         name: "mono_repo; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: mono_repo
         run: pub upgrade --no-precompile
       - name: "mono_repo; pub run test -t yaml --test-randomize-ordering-seed=random"
@@ -525,9 +556,11 @@ jobs:
         with:
           release-channel: dev
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: test_pkg_pub_upgrade
         name: "test_pkg; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: test_pkg
         run: pub upgrade --no-precompile
       - name: "test_pkg; pub run test --test-randomize-ordering-seed=random"

diff --git a/.travis.yml b/.travis.yml
@@ -1,4 +1,4 @@
-# Created with package:mono_repo v3.4.3
+# Created with package:mono_repo v3.4.4
 language: dart
 
 jobs:

diff --git a/mono_repo/CHANGELOG.md b/mono_repo/CHANGELOG.md
@@ -1,3 +1,11 @@
+## 3.4.4
+
+### GitHub Actions
+
+- Always run `pub upgrade|get` steps if checkout succeeds. This ensures that
+  tests runs for all packages, even if one package test fails in the same
+  job.
+
 ## 3.4.3
 
 ### GitHub Actions

diff --git a/mono_repo/lib/src/commands/github/github_yaml.dart b/mono_repo/lib/src/commands/github/github_yaml.dart
@@ -252,6 +252,9 @@ extension on CIJobEntry {
         '$package; $pubCommand',
         pubCommand,
         id: pubStepId,
+        // Run this regardless of the success of other steps other than the
+        // pub step.
+        ifCondition: "always() && steps.checkout.conclusion == 'success'",
         workingDirectory: package,
       ));
       for (var i = 0; i < commands.length; i++) {
@@ -383,7 +386,10 @@ Map<String, dynamic> _githubJobYaml(
           ),
         _createDartSetup(dartVersion),
         {'run': 'dart --version'},
-        {'uses': 'actions/checkout@v2'},
+        {
+          'id': 'checkout',
+          'uses': 'actions/checkout@v2',
+        },
         for (var command in runCommands) command.runContent,
       ],
     };

diff --git a/mono_repo/lib/src/version.dart b/mono_repo/lib/src/version.dart
diff --git a/mono_repo/pubspec.yaml b/mono_repo/pubspec.yaml
@@ -2,7 +2,7 @@ name: mono_repo
 description: >-
   CLI tools to make it easier to manage a single source repository containing
   multiple Dart packages.
-version: 3.4.3
+version: 3.4.4
 repository: https://github.com/google/mono_repo.dart
 
 environment:

diff --git a/mono_repo/test/script_integration_outputs/readme_github_defaults.txt b/mono_repo/test/script_integration_outputs/readme_github_defaults.txt
@@ -34,9 +34,11 @@ jobs:
         with:
           release-channel: dev
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: sub_pkg_pub_upgrade
         name: "sub_pkg; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: sub_pkg
         run: pub upgrade --no-precompile
       - name: sub_pkg; pub run test
@@ -61,9 +63,11 @@ jobs:
         with:
           release-channel: dev
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: sub_pkg_pub_upgrade
         name: "sub_pkg; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: sub_pkg
         run: pub upgrade --no-precompile
       - name: sub_pkg; pub run test
@@ -81,9 +85,11 @@ jobs:
         with:
           release-channel: dev
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: sub_pkg_pub_upgrade
         name: "sub_pkg; pub.bat upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: sub_pkg
         run: pub.bat upgrade --no-precompile
       - name: sub_pkg; pub run test

diff --git a/mono_repo/test/script_integration_outputs/readme_github_lints.txt b/mono_repo/test/script_integration_outputs/readme_github_lints.txt
@@ -32,7 +32,8 @@ jobs:
         with:
           release-channel: stable
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - name: mono_repo self validate
         run: pub global activate mono_repo 1.2.3
       - name: mono_repo self validate
@@ -55,9 +56,11 @@ jobs:
         with:
           release-channel: dev
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: sub_pkg_pub_upgrade
         name: "sub_pkg; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: sub_pkg
         run: pub upgrade --no-precompile
       - name: sub_pkg; dartanalyzer .
@@ -82,9 +85,11 @@ jobs:
         with:
           release-channel: dev
       - run: dart --version
-      - uses: actions/checkout@v2
+      - id: checkout
+        uses: actions/checkout@v2
       - id: sub_pkg_pub_upgrade
         name: "sub_pkg; pub upgrade --no-precompile"
+        if: "always() && steps.checkout.conclusion == 'success'"
         working-directory: sub_pkg
         run: pub upgrade --no-precompile
       - name: "sub_pkg; dartfmt -n --set-exit-if-changed ."

diff --git a/tool/ci.sh b/tool/ci.sh
@@ -1,5 +1,5 @@
 #!/bin/bash
-# Created with package:mono_repo v3.4.3
+# Created with package:mono_repo v3.4.4
 
 # Support built in commands on windows out of the box.
 function pub() {