Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Within a job, continuing running tasks for pkg N+1, even if pkg N fails #296

Closed
kevmoo opened this issue Jan 13, 2021 · 1 comment · Fixed by #297
Closed

Within a job, continuing running tasks for pkg N+1, even if pkg N fails #296

kevmoo opened this issue Jan 13, 2021 · 1 comment · Fixed by #297
Assignees

Comments

@kevmoo
Copy link
Collaborator

kevmoo commented Jan 13, 2021

      - run: dart --version
      - uses: actions/checkout@v2
      # should have an ID here
      - id: mono_repo_pub_upgrade
        name: "mono_repo; pub upgrade --no-precompile"
        working-directory: mono_repo
        run: pub upgrade --no-precompile
      - name: "mono_repo; dartfmt -n --set-exit-if-changed ."
        if: "steps.mono_repo_pub_upgrade.conclusion == 'success'"
        working-directory: mono_repo
        run: dartfmt -n --set-exit-if-changed .
      - name: "mono_repo; dartanalyzer --fatal-infos ."
        if: "steps.mono_repo_pub_upgrade.conclusion == 'success'"
        working-directory: mono_repo
        run: dartanalyzer --fatal-infos .
      - id: test_pkg_pub_upgrade
        name: "test_pkg; pub upgrade --no-precompile"
        working-directory: test_pkg
        run: pub upgrade --no-precompile
       # should have an `if` here based on if checkout succeeds! Should still run if pkg:mono_repo fails
      - name: "test_pkg; dartfmt -n --set-exit-if-changed ."
        if: "steps.test_pkg_pub_upgrade.conclusion == 'success'"
        working-directory: test_pkg
        run: dartfmt -n --set-exit-if-changed .
      - name: "test_pkg; dartanalyzer --fatal-infos ."
        if: "steps.test_pkg_pub_upgrade.conclusion == 'success'"
        working-directory: test_pkg
        run: dartanalyzer --fatal-infos .
@kevmoo
Copy link
Collaborator Author

kevmoo commented Jan 13, 2021

CC @jakemac53 – FYI

kevmoo added a commit that referenced this issue Jan 13, 2021
@kevmoo kevmoo self-assigned this Jan 13, 2021
kevmoo added a commit that referenced this issue Jan 13, 2021
...within the same job

Fixes #296

Prepare to release v3.4.4
kevmoo added a commit that referenced this issue Jan 14, 2021
...within the same job

Fixes #296

Prepare to release v3.4.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant