-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to WiX v4 in Windows #894
Comments
hiroyuki-komatsu
pushed a commit
that referenced
this issue
Mar 13, 2024
This is a preparation to switch to WiX v4 (#894). While there is an automated converter from WiX v3 rules to WiX v4 rules, it normalizes all the single quotes in XML attributes to double quotes. To minimize the diffs in the above process, this commit applies the same normalization in prior. This is a mechanical replacement. There must be no difference in the final installer files. #codehealth PiperOrigin-RevId: 614782079
hiroyuki-komatsu
pushed a commit
that referenced
this issue
Mar 13, 2024
This is a preparation to switch to WiX v4 (#894). While there is an automated converter from WiX v3 rules to WiX v4 rules, it normalizes all the tag ending as follows. * <SomeTag SomeAttr="" /> * <SomeTag SomeAttr="">...</SomeTag> To minimize the diffs in the above process, this commit applies the same normalization in prior. This is a mechanical replacement. There must be no difference in the final installer files. #codehealth PiperOrigin-RevId: 614811737
hiroyuki-komatsu
pushed a commit
that referenced
this issue
Mar 13, 2024
This is a preparation to switch to WiX v4 (#894). While there is an automated converter from WiX v3 rules to WiX v4 rules, it normalizes every XML tag to a single line. To minimize the diffs in the above process, this commit applies the same normalization in prior. This is a mechanical replacement. There must be no difference in the final installer files. #codehealth PiperOrigin-RevId: 614834603
hiroyuki-komatsu
pushed a commit
that referenced
this issue
Mar 13, 2024
This is a preparation to switch to WiX v4 (#894). While there is an automated converter from WiX v3 rules to WiX v4 rules, it mechanically replaces <CustomAction ... BinaryKey="mozc_installer_helper.dll" ... /> with <CustomAction ... BinaryRef="mozc_installer_helper.dll" />. To minimize the diffs in the above process, this commit applies the same normalization in prior. This is a mechanical replacement. There must be no difference in the final installer files. #codehealth PiperOrigin-RevId: 614945481
hiroyuki-komatsu
pushed a commit
that referenced
this issue
Mar 13, 2024
This is a preparation to switch to WiX v4 (#894). While there is an automated converter from WiX v3 rules to WiX v4 rules, it <Directory> section to the last part in the WiX rule file. To minimize the diffs in the above process, this commit applies the same normalization in prior. This is a mechanical replacement. There must be no difference in the final installer files. #codehealth PiperOrigin-RevId: 614965536
hiroyuki-komatsu
pushed a commit
that referenced
this issue
Apr 11, 2024
This is a preparation to switch to WiX v4 (#894). Historically Mozc's WiX rules have had the following actions in <InstallExecuteSequence> * <SelfRegModules /> * <SelfUnfegModules />, which are used for so-called SelfRegistration [1]. However we have explicitly stopped supporting SelfRegistration [2] because 1) we believe SelfRegistration is not the best approach for end user and production and 2) Windows Installer, which Mozc has already relied on, is a supserset of SelfRegistration anyway. With above let's simplify our WiX rules to make it clear that Mozc no longer relies on SelfRegistration in any possible way. Simplifying WiX rules also helps our migration from WiX v3 rules to WiX v4 rules. There must be no user observable behavior change in Mozc64.msi. I have actually confirmed it by manually checking InstallExecuteSequence table in Mozc64.msi by using Orca [3]. #codehealth [1]: https://learn.microsoft.com/en-us/windows/win32/com/self-registration [2]: 4e12191 [3]: https://learn.microsoft.com/en-us/windows/win32/msi/orca-exe PiperOrigin-RevId: 623631510
hiroyuki-komatsu
added a commit
that referenced
this issue
Apr 25, 2024
Features * Updated the word dictionary * Improved the usability of era-to-ad conversion (れいわ6ねん→2024年) Bug fix * Linux: Prevent executing multiple candidate windows (#912) Build * Updated the Protobuf version: v26.0 → v26.1 (#913) * Updated the Qt version: 6.6.3 → 6.7.0 (#911) * Linux: Deprecated the GYP build * Windows: Update the WiX version: v3.14 → v4.0.5 (#894) PiperOrigin-RevId: 627570103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
WiX v3 will be EOLed on Feb 6 2025. It's time to switch to WiX v4 or newer.
https://www.firegiant.com/blog/2024/2/6/wix-security-releases-available/
Version or commit-id
e87c83f
Environment
Additional Information
The text was updated successfully, but these errors were encountered: