Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Added a top-bar button that links to the GitHub repo #18

Merged
merged 2 commits into from
Jan 11, 2018

Conversation

mikesamuel
Copy link
Contributor

Addresses #15

@mikesamuel
Copy link
Contributor Author

The GitHub logo comes from https://github.com/logos which explicitly allows its use for linking to GitHub.

@MylesBorins
Copy link
Contributor

Mostly looks good. Since the github logo is a direct link it is now resizing on hover, which is inconsistent with the other buttons

@mikesamuel
Copy link
Contributor Author

I'm guessing that's related to some :hover default gitbook styles.

@MylesBorins
Copy link
Contributor

MylesBorins commented Jan 11, 2018

Following diff fixes it

diff --git a/styles/website.css b/styles/website.css
index a9f02de..81c790a 100644
--- a/styles/website.css
+++ b/styles/website.css
@@ -26,12 +26,13 @@

 .github-button.btn.links-link {
     display: inline-block;
-    width: 32px;
+    width: 30px;
     font-size: 0;
     background-image: url("/images/GitHub-Mark-32px.png");
     background-repeat: no-repeat;
     background-position: center center;
     opacity: 0.25;
+    background-size: 20px;
 }

although it doesn't have a highlight on hover, but we can fix that in a followup as the other custom link doesn't have it either

@mikesamuel
Copy link
Contributor Author

Folded your fix into this PR. Thanks.

@mikesamuel mikesamuel merged commit c29fa7a into master Jan 11, 2018
@mikesamuel mikesamuel deleted the github-button branch January 11, 2018 05:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants