-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change domain-check fee responses for registrars in tiered promos #2489
Conversation
60a8467
to
43fb88e
Compare
friendly ping |
As requested, for registrars participating in these tiered pricing promos that wish to receive this type of response, we make the following changes: 1. The non-promotional (i.e. incorrect) price is returned as the standard domain-create fee when running a domain check. 2. The promotional (i.e. correct) price is returned as a special custom command class with a name of "STANDARD PROMO" when running a domain check 3. Domain creates will return the non-promotional (i.e. incorrect) price rather than the actual promotional price. This PR does only number 3. See PR google#2489 for the others.
As requested, for registrars participating in these tiered pricing promos that wish to receive this type of response, we make the following changes: 1. The non-promotional (i.e. incorrect) price is returned as the standard domain-create fee when running a domain check. 2. The promotional (i.e. correct) price is returned as a special custom command class with a name of "STANDARD PROMO" when running a domain check 3. Domain creates will return the non-promotional (i.e. incorrect) price rather than the actual promotional price. This PR does only number 3. See PR google#2489 for the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah, for bullet point 1, rather than saying the "incorrect" price, I would call it the pre-promotion, "base tier" price. Pricing tiers is after all how basically all registrars think about domain pricing, even if we don't.
Reviewable status: 0 of 8 files reviewed, all discussions resolved
As requested, for registrars participating in these tiered pricing promos that wish to receive this type of response, we make the following changes: 1. The pre-promotional (i.e. base tier) price is returned as the standard domain-create fee when running a domain check. 2. The promotional (i.e. correct) price is returned as a special custom command class with a name of "STANDARD PROMO" when running a domain check 3. Domain creates will return the non-promotional (i.e. incorrect) price rather than the actual promotional price. This PR does only number 3. See PR google#2489 for the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed the wording, hah
Reviewable status: 0 of 8 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 8 files reviewed, 2 unresolved discussions (waiting on @gbrodman)
core/src/main/java/google/registry/model/domain/fee/FeeQueryCommandExtensionItem.java
line 43 at r1 (raw file):
RESTORE(true), UPDATE(false), // We don't accept CUSTOM commands in requests but may issue them in responses.
This should be a Javadoc.
core/src/main/java/google/registry/model/domain/fee/FeeQueryCommandExtensionItem.java
line 52 at r1 (raw file):
try { CommandName command = valueOf(string); checkArgument(!command.equals(UNKNOWN) && !command.equals(CUSTOM));
At this point it's worth adding a second parameter to the enum constructor that specifies whether it is acceptable for the enum value to be present in domain check requests, which will be false for both UNKNOWN
and CUSTOM
and true for all others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo some nits.
Reviewable status: 0 of 8 files reviewed, 2 unresolved discussions (waiting on @gbrodman)
As requested, for registrars participating in these tiered pricing promos that wish to receive this type of response, we make the following changes: 1. The pre-promotional (i.e. base tier) price is returned as the standard domain-create fee when running a domain check. 2. The promotional (i.e. correct) price is returned as a special custom command class with a name of "STANDARD PROMO" when running a domain check 3. Domain creates will return the non-promotional (i.e. incorrect) price rather than the actual promotional price. This PR does only number 3. See PR google#2489 for the others.
43fb88e
to
a8c82e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 8 files reviewed, 2 unresolved discussions (waiting on @CydeWeys)
core/src/main/java/google/registry/model/domain/fee/FeeQueryCommandExtensionItem.java
line 43 at r1 (raw file):
Previously, CydeWeys (Ben McIlwain) wrote…
This should be a Javadoc.
Done.
core/src/main/java/google/registry/model/domain/fee/FeeQueryCommandExtensionItem.java
line 52 at r1 (raw file):
Previously, CydeWeys (Ben McIlwain) wrote…
At this point it's worth adding a second parameter to the enum constructor that specifies whether it is acceptable for the enum value to be present in domain check requests, which will be false for both
UNKNOWN
andCUSTOM
and true for all others.
as discussed offline, this does not correspond to domain check requests but rather token actions. Either way, we can do some sort of "acceptable input option" thing
a8c82e1
to
5415f16
Compare
As requested, for registrars participating in these tiered pricing promos that wish to receive this type of response, we make the following changes: 1. The pre-promotional (i.e. base tier) price is returned as the standard domain-create fee when running a domain check. 2. The promotional (i.e. correct) price is returned as a special custom command class with a name of "STANDARD PROMO" when running a domain check 3. Domain creates will return the non-promotional (i.e. incorrect) price rather than the actual promotional price. This PR does only number 3. See PR google#2489 for the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 8 files reviewed, all discussions resolved
As requested, for registrars participaing in these tiered pricing promos that wish to receive this type of response, we make the following changes: 1. The non-promotional (i.e. incorrect) price is returned as the standard domain-create fee when running a domain check. 2. The promotional (i.e. correct) price is returned as a special custom command class with a name of "STANDARD PROMO" when running a domain check. 3. Domain creates will return the non-promotional (i.e. incorrect) price rather than the actual promotional price. This is not implemented in this PR.
5415f16
to
5300c63
Compare
As requested, for registrars participating in these tiered pricing promos that wish to receive this type of response, we make the following changes: 1. The pre-promotional (i.e. base tier) price is returned as the standard domain-create fee when running a domain check. 2. The promotional (i.e. correct) price is returned as a special custom command class with a name of "STANDARD PROMO" when running a domain check 3. Domain creates will return the non-promotional (i.e. incorrect) price rather than the actual promotional price. This PR does only number 3. See PR google#2489 for the others.
As requested, for registrars participating in these tiered pricing promos that wish to receive this type of response, we make the following changes: 1. The pre-promotional (i.e. base tier) price is returned as the standard domain-create fee when running a domain check. 2. The promotional (i.e. correct) price is returned as a special custom command class with a name of "STANDARD PROMO" when running a domain check 3. Domain creates will return the non-promotional (i.e. incorrect) price rather than the actual promotional price. This PR does only number 3. See PR google#2489 for the others.
As requested, for registrars participating in these tiered pricing promos that wish to receive this type of response, we make the following changes: 1. The pre-promotional (i.e. base tier) price is returned as the standard domain-create fee when running a domain check. 2. The promotional (i.e. correct) price is returned as a special custom command class with a name of "STANDARD PROMO" when running a domain check 3. Domain creates will return the non-promotional (i.e. incorrect) price rather than the actual promotional price. This PR does only number 3. See PR #2489 for the others.
As requested, for registrars participaing in these tiered pricing promos that wish to receive this type of response, we make the following changes:
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)