Change domain-check fee responses for registrars in tiered promos

[gbrodman]

As requested, for registrars participaing in these tiered pricing promos that wish to receive this type of response, we make the following changes:

1. The pre-promotional (i.e. base tier) price is returned as the standard domain-create fee when running a domain check.
2. The promotional (i.e. correct) price is returned as a special custom command class with a name of "STANDARD PROMO" when running a domain check.
3. Domain creates will return the non-promotional (i.e. incorrect) price rather than the actual promotional price. This is not implemented in this PR.

---

This change is 

[gbrodman]

friendly ping

[CydeWeys]

Hah, for bullet point 1, rather than saying the "incorrect" price, I would call it the pre-promotion, "base tier" price. Pricing tiers is after all how basically all registrars think about domain pricing, even if we don't.

Reviewable status: 0 of 8 files reviewed, all discussions resolved

[gbrodman]

changed the wording, hah

Reviewable status: 0 of 8 files reviewed, all discussions resolved

[CydeWeys]

Reviewable status: 0 of 8 files reviewed, 2 unresolved discussions (waiting on @gbrodman)

---

core/src/main/java/google/registry/model/domain/fee/FeeQueryCommandExtensionItem.java line 43 at r1 (raw file):

    RESTORE(true),
    UPDATE(false),
    // We don't accept CUSTOM commands in requests but may issue them in responses.

This should be a Javadoc.

---

core/src/main/java/google/registry/model/domain/fee/FeeQueryCommandExtensionItem.java line 52 at r1 (raw file):

      try {
        CommandName command = valueOf(string);
        checkArgument(!command.equals(UNKNOWN) && !command.equals(CUSTOM));

At this point it's worth adding a second parameter to the enum constructor that specifies whether it is acceptable for the enum value to be present in domain check requests, which will be false for both UNKNOWN and CUSTOM and true for all others.

[CydeWeys]

LGTM modulo some nits.

Reviewable status: 0 of 8 files reviewed, 2 unresolved discussions (waiting on @gbrodman)

[gbrodman]

Reviewable status: 0 of 8 files reviewed, 2 unresolved discussions (waiting on @CydeWeys)

---

core/src/main/java/google/registry/model/domain/fee/FeeQueryCommandExtensionItem.java line 43 at r1 (raw file):

Previously, CydeWeys (Ben McIlwain) wrote…

This should be a Javadoc.

Done.

---

core/src/main/java/google/registry/model/domain/fee/FeeQueryCommandExtensionItem.java line 52 at r1 (raw file):

Previously, CydeWeys (Ben McIlwain) wrote…

At this point it's worth adding a second parameter to the enum constructor that specifies whether it is acceptable for the enum value to be present in domain check requests, which will be false for both UNKNOWN and CUSTOM and true for all others.

as discussed offline, this does not correspond to domain check requests but rather token actions. Either way, we can do some sort of "acceptable input option" thing

[CydeWeys]

Reviewable status: 0 of 8 files reviewed, all discussions resolved