Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more changes to make it possible to use Java 11 to compile #732

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

jianglai
Copy link
Collaborator

@jianglai jianglai commented Jul 31, 2020

Add the class paths of the source files generated by annotation processors to
the javadoc task's class path so that it doesn't complain about missing
Dagger classes.

Also remove empty

tags in all generated source files, because jaxb
genrerates files in multiple locations.

Lastly, for unkown reasons when the source level is set to > 8, the core
subproject throws a warning about a Gradle internal annotator processor
that only supports up to Java 8 and cause the Java compliation to fail because
we set -Werror on all java compilation tasks. I don't think there is a
strong reason that we set -Werror anyway, so this commit removes it.


This change is Reviewable

@jianglai jianglai requested a review from mindhog July 31, 2020 00:02
@google-cla google-cla bot added the cla: yes label Jul 31, 2020
@jianglai jianglai added the kokoro:force-run Force a Kokoro build. label Jul 31, 2020
@domain-registry-eng domain-registry-eng removed the kokoro:force-run Force a Kokoro build. label Jul 31, 2020
@jianglai jianglai added the kokoro:force-run Force a Kokoro build. label Jul 31, 2020
@domain-registry-eng domain-registry-eng removed the kokoro:force-run Force a Kokoro build. label Jul 31, 2020
Copy link
Member

@mindhog mindhog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jianglai)


java_common.gradle, line 105 at r1 (raw file):

    if (System.getProperty('no_werror') != 'true') {
        options.compilerArgs << "-Werror"
    }

I'm a little concerned about this. Typically we do -Werror in order to be very aggressive about keeping the code free of warnings. I'm not sure what else to do about it, though. At minimum we should resurrect this when we have all the necessary gradle support.

Add the class paths of the source files generated by annotation processors to
the javadoc task's class path so that it doesn't complain about missing
Dagger classes.

Also remove empty <p> tags in all generated source files, because jaxb
genrerates files in multiple locations.

Lastly, for unkown reasons when the source level is set to > 8, the core
subproject throws a warning about a Gradle internal annotator processor
that only supports up to Java 8 and cause the Java compliation to fail because
we set -Werror on all java compliation tasks. I don't think there is a
strong reason that we set -Werror anyway, so this commit removes it.
@jianglai jianglai added the kokoro:force-run Force a Kokoro build. label Jul 31, 2020
@domain-registry-eng domain-registry-eng removed the kokoro:force-run Force a Kokoro build. label Jul 31, 2020
@jianglai jianglai merged commit 090c233 into google:master Jul 31, 2020
@jianglai jianglai deleted the java11 branch July 31, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants