Modify proxy to pass full certificate before login

[sarahcaseybot]

This change is 

[CydeWeys]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @CydeWeys and @sarahcaseybot)

---

proxy/src/main/java/google/registry/proxy/handler/EppServiceHandler.java, line 154 at r1 (raw file):

                Base64.getEncoder().encodeToString(sslClientCertificate.getEncoded()));
      } catch (CertificateEncodingException e) {
        throw new RuntimeException("Cannot encode client certificate.", e);

Nit: No periods at end of exception messages. (This is how Java's standard library does it; I don't make the rules, I promise!)

---

proxy/src/test/java/google/registry/proxy/TestUtils.java, line 123 at r1 (raw file):

        .headers()
        .set(
            "X-SSL-Full-Certificate", Base64.getEncoder().encodeToString(certificate.getEncoded()));

This is duplicating the logic under test, and thus isn't actually testing that the encoding is working properly.

Can you have the test below use an actual hard-coded Base64-encoded string? That way if the encoder behavior changes for some reason, we'll actually get a test failure, rather than the test continuing to pass but with different behavior.

[sarahcaseybot]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @CydeWeys)

---

proxy/src/test/java/google/registry/proxy/TestUtils.java, line 123 at r1 (raw file):

Previously, CydeWeys (Ben McIlwain) wrote…

This is duplicating the logic under test, and thus isn't actually testing that the encoding is working properly.

Can you have the test below use an actual hard-coded Base64-encoded string? That way if the encoder behavior changes for some reason, we'll actually get a test failure, rather than the test continuing to pass but with different behavior.

Done.

[CydeWeys]

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @CydeWeys)