Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if displayName exists #114

Merged
merged 1 commit into from Mar 20, 2021
Merged

Check if displayName exists #114

merged 1 commit into from Mar 20, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 17, 2021

When we are using ldap_ad = 1 config, if a user object has not displayName property, the map updater fails.

  • DisplayName is not an mandatory field in AD and gecos it's only a descritive field en linux

Fix error:

pw.gecos = obj['displayName'][0]
KeyError: 'displayName'

When we are using `ldap_ad = 1` config, if user object has not `displayName` property, the map updater fails.

* DisplayName is not an mandatory field in AD and gecos it's only a descritive field en linux
@google-cla
Copy link

google-cla bot commented Mar 17, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ghost
Copy link
Author

ghost commented Mar 17, 2021

@googlebot I signed it!

@jaqx0r
Copy link
Contributor

jaqx0r commented Mar 20, 2021

Thanks for the fix!

@jaqx0r jaqx0r merged commit 8725f96 into google:main Mar 20, 2021
@lpcalisi
Copy link

Thanks for merge, when the changes will be upgraded in debian package?

@jaqx0r
Copy link
Contributor

jaqx0r commented Mar 30, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants