Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Proof Key for Code Exchange with SHA-256 #110

Closed
DemiMarie opened this issue Oct 7, 2020 · 2 comments
Closed

Use Proof Key for Code Exchange with SHA-256 #110

DemiMarie opened this issue Oct 7, 2020 · 2 comments
Assignees
@andyrzhao

Comments

@DemiMarie
Copy link

This is a prerequisite for #37, as otherwise oauth2l would be vulnerable to a local information leak attack in certain (rare) scenarios.
@andyrzhao andyrzhao self-assigned this May 17, 2021
@andyrzhao
Copy link
Collaborator

OAuth2 golang core lib has just been updated to support PKCE params in the auth handler interface here: golang/oauth2#568. Need one more PR to update oauth2l to use the new PKCE interface. #37 is currently being worked on independently. Both issues should be resolved by end of Q2 2022.

@andyrzhao
Copy link
Collaborator

PKCE integration added in #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyrzhao andyrzhao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DemiMarie @andyrzhao