Add support for PKCE #136
Merged
Add support for PKCE #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andyrzhao
commented
Jun 30, 2022
andyrzhao
commented
- Adds PKCE params to fetch code-path, using helper function from pkce.go.
- Updates go mod version to 1.16 since the latest version of oauth2 core lib has a dependency on 1.16 API. Update vendors.
- Ensure hostname is fully specified (i.e. localhost:8080 instead of :8080) in cli_test.go and loopback.go, to avoid a MacOS security pop-up.
ulisesL
reviewed
Jun 30, 2022
| @@ -309,10 +309,10 @@ func getListener(address string) (listener *net.Listener, serverAddress string, | |||
|
|
|||
| if match == "" { // Case: No given port provided for localhost | |||
| // Creating a listener on the next available port | |||
| l, err = net.Listen("tcp", ":0") | |||
| l, err = net.Listen("tcp", "localhost:0") | |||
There was a problem hiding this comment.
Good observation. From the documentation it looks like they do not recommend having a hostname. The documentation can be found here: https://pkg.go.dev/net#Listener. In short, this is what it says:
The address can use a host name, but this is not recommended, because it will create a listener for at most one of the host's IP addresses.
There was a problem hiding this comment.
Thanks for the suggestions. I reviewed the official documentation and feel like the recommendation does not explicitly discourage localhost, but rather discourage a hard-coded fqdn, which may vary depending on where the code is deployed. So this should not be an issue for our use-case.
ulisesL
reviewed
Jun 30, 2022
| } else { // Case: Port provided for localhost | ||
| // Creating a listener on the provided port | ||
| l, err = net.Listen("tcp", strings.Replace(match, "localhost", "", 1)) |
There was a problem hiding this comment.
Thanks for looking into this. Maybe the same (please see comment above) can be applied here.
ulisesL
reviewed
Jun 30, 2022
ulisesL
approved these changes
Jul 1, 2022
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.