Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OboeTester: DataCallbackResult::Stop not stopping the INPUT stream #576

Closed
philburk opened this issue Jul 13, 2019 · 3 comments
Closed

OboeTester: DataCallbackResult::Stop not stopping the INPUT stream #576

philburk opened this issue Jul 13, 2019 · 3 comments
Assignees
@philburk
Labels
bug

Comments

@philburk
Copy link
Collaborator

Android Version(s): QT
Android Device(s): Pixel 3a
Oboe Version: 1.2.0

Steps To Reproduce
Launch OboeTester
TEST IINPUT
OPEN
START
Check "callback returns STOP"

Expected behavior
Stream stops.

Actual behavior
Stream continues in Started mode but does not deliver any input data.

Additional context

If applicable, please attach a recording of the sound.
@philburk philburk self-assigned this Jul 13, 2019
@atneya
Copy link
Collaborator

atneya commented Jul 13, 2019

OboeTester (older version from a few weeks ago) on PixelXL, Android Q, does not reproduce.

@philburk philburk changed the title OboeTester: DataCallbackResult::Stop not stopping the stream OboeTester: DataCallbackResult::Stop not stopping the INPUT stream Jul 17, 2019
@philburk
Copy link
Collaborator Author

philburk commented Jul 17, 2019 •
edited
Loading

OboeTester V1.4.06 on Sargo on recent QT - PASS

I think this may just be a temporary issue in the code that is adding resampling. #530

@philburk philburk added the bug label Jul 17, 2019
philburk pushed a commit that referenced this issue Aug 23, 2019
resampler: pass callback result
99c0048 
from child stream to parent.
Fixes #576
@philburk
Copy link
Collaborator Author

Fixed in resampler branch. This bug was never in release code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philburk philburk

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philburk @atneya