Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add openSharedStream() to prevent deletion while executing onError callbacks #821

Merged
merged 4 commits into from
May 1, 2020
Merged

Add openSharedStream() to prevent deletion while executing onError callbacks #821

merged 4 commits into from
May 1, 2020

Conversation

philburk
Copy link
Collaborator

@philburk philburk commented Apr 15, 2020 •
edited
Loading

Fixes #820

@philburk
oboe: add openSharedStream
68f7df0 
To prevent race conditions with the onError callbacks
that were resulting in the use of a deleted stream.

For bug #820
@philburk
OboeTester: use openSharedStream()
c4556cc 
Also added a sleep to provoke a race condition. Should be removed.
dturner
dturner reviewed Apr 22, 2020
View reviewed changes
include/oboe/AudioStream.h Outdated Show resolved Hide resolved
@philburk
Oboe: openSharedStream uses ResultWithView
df6d638 
Also use a friend class to hide ssetWeakThis().
dturner
dturner approved these changes Apr 23, 2020
View reviewed changes
Copy link
Collaborator

@dturner dturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for making these changes! LGTM.

src/common/AudioStreamBuilder.cpp Outdated Show resolved Hide resolved
include/oboe/AudioStreamBuilder.h Outdated Show resolved Hide resolved
@dturner dturner mentioned this pull request Apr 23, 2020
Closed
@philburk
oboe: shared_ptr to stream
da7f9cc 
Changed openSharedStream() to openStream().
Remove version with ResultWithValue<shared_ptr>
Bump oboe version to 1.4.0
Bump oboetester version to 1.5.24
@philburk philburk merged commit ab625b6 into master May 1, 2020
@philburk philburk deleted the deleterace branch May 1, 2020 22:01
@Rodrigodd Rodrigodd mentioned this pull request Aug 22, 2022
Closed
@kus04e4ek kus04e4ek mentioned this pull request Mar 9, 2024
Draft
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dturner dturner dturner approved these changes

@mnaganov mnaganov Awaiting requested review from mnaganov

@ggfan ggfan Awaiting requested review from ggfan

@android-usb android-usb Awaiting requested review from android-usb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AudioStreamCallback design prone to race conditions
3 participants
@philburk @rpattabi @dturner