Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add openSharedStream() to prevent deletion while executing onError callbacks #821

Merged
merged 4 commits into from
May 1, 2020
Merged

Add openSharedStream() to prevent deletion while executing onError callbacks #821

merged 4 commits into from
May 1, 2020

Commits on Apr 15, 2020

  1. oboe: add openSharedStream 

    To prevent race conditions with the onError callbacks
that were resulting in the use of a deleted stream.

For bug #820
    @philburk
    philburk committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    68f7df0 View commit details
    Browse the repository at this point in the history

  2. OboeTester: use openSharedStream() 

    Also added a sleep to provoke a race condition. Should be removed.
    @philburk
    philburk committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    c4556cc View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2020

  1. Oboe: openSharedStream uses ResultWithView 

    Also use a friend class to hide ssetWeakThis().
    @philburk
    philburk committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    df6d638 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. oboe: shared_ptr to stream 

    Changed openSharedStream() to openStream().
Remove version with ResultWithValue<shared_ptr>
Bump oboe version to 1.4.0
Bump oboetester version to 1.5.24
    @philburk
    philburk committed Apr 24, 2020
    1 Configuration menu
    Copy the full SHA
    da7f9cc View commit details
    Browse the repository at this point in the history