Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use future version of raise_with_traceback for Python 2.7 compatibility #890

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use future version of raise_with_traceback for Python 2.7 compatibility #890

wants to merge 1 commit into from

Conversation

daiweili
Copy link
Contributor

@daiweili daiweili commented Jul 1, 2019 •
edited by kdsudac
Loading

This change is Reviewable

arsharma1
arsharma1 reviewed Jul 10, 2019
View reviewed changes
openhtf/util/test.py
@@ -114,6 +114,7 @@ def test_multiple(self, mock_my_plug):

import collections
import functools
from future.utils import raise_with_traceback
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use six.reraise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arsharma1 arsharma1 arsharma1 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daiweili @arsharma1