Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App object has no attribute get_binary #79

Closed
mweinelt opened this issue Mar 12, 2020 · 2 comments · Fixed by #100
Closed

App object has no attribute get_binary #79

mweinelt opened this issue Mar 12, 2020 · 2 comments · Fixed by #100
Assignees

Comments

@mweinelt
Copy link

mweinelt commented Mar 12, 2020

Expected Behavior

deploy.py should build the image to be flashed.

Actual Behavior

It fails with an AttributeError, because there is no function defintion for get_binary(). Looks to me like the issue was introduced in #78

% ./deploy.py --board=nrf52840_mdk_dfu --opensk --programmer=none
info: Updating rust toolchain to nightly-2020-02-03
info: syncing channel updates for 'nightly-2020-02-03-x86_64-unknown-linux-gnu'
info: component 'rust-std' for target 'thumbv7em-none-eabi' is up to date
info: Rust toolchain up-to-date
info: Building Tock OS for board nrf52840_mdk_dfu
    Finished release [optimized + debuginfo] target(s) in 0.49s
info: Building OpenSK application
    Finished release [optimized] target(s) in 0.64s
info: Generating Tock TAB file for application/example ctap2
Traceback (most recent call last):
  File "./deploy.py", line 772, in <module>
    main(main_parser.parse_args())
  File "./deploy.py", line 645, in main
    OpenSKInstaller(args).run()
  File "./deploy.py", line 595, in run
    self.create_hex_file(dest_file)
  File "./deploy.py", line 508, in create_hex_file
    app_tab.extract_app(board_props.arch).get_binary(),
AttributeError: 'App' object has no attribute 'get_binary'

Steps to Reproduce the Problem

  1. ./setup.sh
  2. ./deploy.py --board=nrf52540_mdk_dfu --opensk --programmer=none

Specifications

  • Version: ec1ce66
  • Platform: Linux x86_64
@jmichelp
Copy link
Collaborator

This is due to tockloader project. The last version available on PyPI is v1.3 and we need v1.4 which isn't released yet.
Brad mentioned he's working on releasing v1.4

@diegobes
Copy link

As a workaround:
1- uninstall tockloader: pip3 uninstall tockloader
2- clone tockloader repository
3- from the tockloader repository root: python3 setup.py install
This will install the latest version from master with App.get_binary support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants