Revamp deploy.py #78
Merged
Revamp deploy.py #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gendx
requested changes
Mar 11, 2020
There was a problem hiding this comment.
Imported 2 patches for Tock kernel:
- 06-add-set_vector_table_offset.patch (upstream tock/tock#1579)
This shouldn't be needed after #77.
- 07-nrf52-bootloader.patch (upstream tock/tock#1681)
2 tasks
Now the script supports more flashing methods: - JLink (with tockloader) - OpenOCD (with tockloader) - pyOCD - Nordic DFU - none (will produce an IntelHex file) Also merged the contributions from: - Yihui Xiong to support the Makerdiary USB dongle board - Dennis Geurts to support Nordic DFU Doc updated accordingly. Imported 2 patches for Tock kernel: - 06-add-set_vector_table_offset.patch (upstream tock/tock#1579) - 07-nrf52-bootloader.patch (upstream tock/tock#1681)
gendx
requested changes
Mar 12, 2020
| info("Installing Tock on board {}".format(self.args.board)) | ||
| self.build_and_install_tockos() | ||
| if not self.args.tockos and not self.args.application: | ||
| info("Nothing to do.") |
There was a problem hiding this comment.
I'd return a non-zero error code in that case so that people are aware they need to provide something to do in their command line?
| @@ -19,8 +19,9 @@ successfully tested on the following boards: | |||
|
|
|||
There was a problem hiding this comment.
Do you want to mention the DFU-based boards in this README? And the DFU limitations regarding re-flashing Tock?
gendx
previously approved these changes
Mar 12, 2020
gendx
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the script supports more flashing methods:
Also merged the contributions from:
Doc updated accordingly.
Imported 2 patches for Tock kernel:
Fixes #3
Fixes #70