Upgrade to kr.motd.maven:os-maven-plugin:1.3.0.Final and expose linux variants. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public Release getRelease() { | ||
| Object releaseId = impl.detectedProperties.get(Detector.DETECTED_RELEASE); | ||
| if (releaseId == null) { | ||
| throw new UnsupportedOperationException("release is not available for " + getClassifier()); |
There was a problem hiding this comment.
Maybe just return null? Also, should we have an isReleaseSupported()?
There was a problem hiding this comment.
I am OK with returning a null. isReleaseSupported() is probably unnecessary because it's idiomatic in Groovy to check a null return value. null is evaluated as false in conditional statement:
if (osdetector.release) {
osdetector.release.isLike(...)
}
|
@zhangkun83 looks great! Just a few minor comments. |
|
@nmittler PTAL. |
|
@zhangkun83 LGTM |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ejona86 @nmittler