-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuzz targets seem to have started failing under MSan on CIFuzz #11886
Comments
This should be fixed by #11887 |
Looking at #11714 it seems it was a bumpy ride :-) It was prudent to turn off the "function" sanitizer there too: systemd/systemd#29972, avahi/avahi#584 |
Yes, the bump was more involved, because it skipped over several clang releases. Be aware that the function sanitizer may in the future be enabled. See #11778 for the tracking issue for that. |
Fixes #11886 --------- Co-authored-by: MarcoFalke <6399679+MarcoFalke@users.noreply.github.com> Co-authored-by: jonathanmetzman <31354670+jonathanmetzman@users.noreply.github.com>
To judge from https://github.com/systemd/systemd/actions/runs/8972741048/job/24641404945 the fuzz targets keep failing on CIFuzz. Could it be that the base images haven't been updated? |
Are we sure this is a CIFuzz issue? I think CIFuzz says this happens with the oss-fuzz builds too. So it seems to be an issue with oss-fuzz. Do you agree? |
I'm not sure. I haven't seen those backtraces there. They don't seem to have been reported on Monorail either. Let me double-check. |
Looks like there are no those backtraces on OSS-Fuzz. I can't reproduce it locally with |
The cifuzz images are building: https://pantheon.corp.google.com/gcr/images/oss-fuzz-base/GLOBAL/cifuzz-base |
From https://github.com/systemd/systemd/actions/runs/8972741048/job/24641404945#step:4:41 it looks recent enough already (from yesterday). As I bumped the cmake version in commit f5e1a6d at the same time, this can be checked via:
Or is there another component in CIFuzz that is not yet updated? |
Yeah something odd happening here. CIFuzz should always be using the latest builder. The latest runner, although it should be used, is a more complicated story. |
Looking at the backtrace it could be that it has something to do with the runtime environment in the sense that
seems to indicate that some file is copied somewhere and maybe it doesn't happen anywhere else. |
OK I can reproduce this now:
|
I guess libFuzzer is no longer MSAN safe. |
I'm going to look at fixing this. |
Ref #11922 |
I restarted CFLite in systemd/systemd-stable#396 and I can no longer see those backtraces. Looks like this issue can be closed. Thanks! |
It should probably reach OSS-Fuzz a bit later.
From systemd/systemd#32609 (comment)
The text was updated successfully, but these errors were encountered: