Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[knot-dns] initial integration #1049

Closed
wants to merge 1 commit into from
Closed

[knot-dns] initial integration #1049

wants to merge 1 commit into from

Conversation

jfoote
Copy link
Contributor

@jfoote jfoote commented Dec 28, 2017

This adds the initial integration for knot-dns. Fuzz targets build/execute as part of knot CI; use corpora from external repos.

Note that the fuzz target builds use the clang6 -fsanitize=fuzzer-no-link flag for compilation and -fsanitize=fuzzer along with -lFuzzingEngine for linking (other sanitizer flags notwithstanding). I didn't find any guidance on the new clang6 flags so I made an educated guess -- if that is incorrect please let me know.

References: initial oss-fuzz project submission, knot-dns merge (gitlab)

@alex
Copy link
Contributor

alex commented Dec 28, 2017

You generally shouldn't need to specify your own -fsanitize flags, they'll automatically be in the $CFLAGS/$CXXFLAGS env vars.

@jfoote
Copy link
Contributor Author

jfoote commented Dec 28, 2017

That is a good point @alex, thanks; nothing special about the clang6 libfuzzer flags. I'll make another PR to knot-dns to update the build system accordingly and re-open this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants