Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmer: revert rust pin #12113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

manunio
Copy link
Contributor

@manunio manunio commented Jun 22, 2024

Reverting rust pin as wasmerio/wasmer#4445 has been fixed.

Copy link

manunio has previously contributed to projects/wasmer. The previous PR was #11583

@manunio manunio marked this pull request as draft June 22, 2024 14:47
@manunio manunio changed the title wasmer: revert rust pin [WIP] wasmer: revert rust pin Jun 24, 2024
@maflcko
Copy link
Contributor

maflcko commented Jun 25, 2024

The error was (in the coverage build):

cp: cannot stat 'target/x86_64-unknown-linux-gnu/release/universal_cranelift': No such file or directory

Also, you'll have to drop the second commit (infra change).

@manunio
Copy link
Contributor Author

manunio commented Jun 25, 2024

The error was (in the coverage build):

Yes, I saw that. As you can see from the build logs, the coverage targets are building within seconds. This shouldn't be happening since projects are built from scratch for every sanitizers(address, coverage).

I was facing the same issue locally. The command build_fuzzers --sanitizer address worked fine, while the coverage was failing, so i reverted this commit deef8c5, and built infra images with following commands which solved coverage issue.

python3 infra/helper.py build_image --no-pull base-builder
python3 infra/helper.py build_image --no-pull base-builder-rust
python infra/helper.py build_image wasmer --no-pull
python infra/helper.py build_fuzzers --sanitizer coverage wasmer
python infra/helper.py coverage wasmer -- '-ignore-filename-regex=.*/rustc/.*'

I'm not sure what the root cause of this problem is, I saw the commit message about freezing container and reverted that, It could be related to that or something else.

@manunio manunio changed the title [WIP] wasmer: revert rust pin wasmer: revert rust pin Jun 28, 2024
@manunio manunio marked this pull request as ready for review June 28, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants