Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[infra] Remove sancov and rename "profile" to "coverage". #1839

Merged
merged 3 commits into from Oct 1, 2018
Merged

[infra] Remove sancov and rename "profile" to "coverage". #1839

merged 3 commits into from Oct 1, 2018

Conversation

Dor1s
Copy link
Contributor

@Dor1s Dor1s commented Sep 24, 2018

Ready for review, but please don't merge it until I land some changes on CF side.

oliverchang
oliverchang reviewed Sep 24, 2018
View reviewed changes
Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one comment.

Also, could you please remove the corresponding code in corpus pruning and oss_fuzz_setup ?

infra/base-images/base-builder/compile Outdated
export COVERAGE_FLAGS=
fi

export CFLAGS="$CFLAGS $SANITIZER_FLAGS $COVERAGE_FLAGS"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is $COVERAGE_FLAGS no longer needed here? don't we need it for regular fuzzing builds?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually SANITIZER_FLAGS is no longer included after this deletion too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch re COVERAGE_FLAGS! Those are still defined by base-builder/Dockerfile and might be overwritten by fuzzing engines compile_* scripts.

SANITIZER_FLAGS should still be there (weird GitHub UI moved them up to line 45).

Either way, I'm bringing this coverage flags override code back, as otherwise it looks confusing to have empty COVERAGE_FLAGS for a coverage build :D

@pdknsk
Copy link
Contributor

pdknsk commented Sep 25, 2018

If this renames $SANITIZER, I'd like to submit some minor changes to project firefox first.

@Dor1s
Copy link
Contributor Author

Dor1s commented Sep 25, 2018

Also, could you please remove the corresponding code in corpus pruning and oss_fuzz_setup ?

yes sure!

If this renames $SANITIZER, I'd like to submit some minor changes to project firefox first.

Thanks for the heads up! Looks like there are some other projects that also rely on profile name, I'd rather update them altogether in the same CL.

@pdknsk
Copy link
Contributor

pdknsk commented Sep 25, 2018

firefox needs a few more changes, which are not immediately obvious.

  • first line $SANITIZER check in build.sh must be removed
  • file mozconfig.profile renamed to mozconfig.coverage
  • other mozconfig files edited to change the mozconfig.profile include

@Dor1s
Copy link
Contributor Author

Dor1s commented Sep 25, 2018

@pdknsk can you please upload a PR which I will merge right before merging mine?

@pdknsk pdknsk mentioned this pull request Sep 25, 2018
Merged
oliverchang
oliverchang approved these changes Sep 25, 2018
View reviewed changes
Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Dor1s Dor1s merged commit 7703e36 into master Oct 1, 2018
Dor1s added a commit that referenced this pull request Oct 1, 2018
@Dor1s
[infra] Remove srcmap related commands from gcb script (follow-up #1839…
f132eaf 
…).
Dor1s added a commit that referenced this pull request Oct 1, 2018
@Dor1s
[infra] Update documentation (new coverage screenshots + some cleanup…
730451d 
…), follow-up #1839).
@inferno-chromium inferno-chromium deleted the remove_sancov branch October 2, 2018 05:32
inferno-chromium added a commit that referenced this pull request Oct 2, 2018
@inferno-chromium
Revert "[infra] Remove srcmap related commands from gcb script (follo…
e6a6d7c 
…w-up #1839)."

This reverts commit f132eaf.
@inferno-chromium inferno-chromium mentioned this pull request Oct 2, 2018
Merged
inferno-chromium added a commit that referenced this pull request Oct 2, 2018
@inferno-chromium
Revert "[infra] Remove srcmap related commands from gcb script (follo…
4afcfab 
…w-up #1839)." (#1848)

This reverts commit f132eaf.
tmatth pushed a commit to tmatth/oss-fuzz that referenced this pull request Oct 22, 2018
@Dor1s @tmatth
[infra] Remove sancov and rename "profile" to "coverage". (google#1839)
b489659 
* [infra] Remove sancov and rename "profile" to "coverage".

* Bring coverage flags back.

* Update projects files that rely on SANITIZER="profile".
tmatth pushed a commit to tmatth/oss-fuzz that referenced this pull request Oct 22, 2018
@Dor1s @tmatth
[infra] Remove srcmap related commands from gcb script (follow-up goo…
b329bd5 
…gle#1839).
tmatth pushed a commit to tmatth/oss-fuzz that referenced this pull request Oct 22, 2018
@Dor1s @tmatth
[infra] Update documentation (new coverage screenshots + some cleanup…
e3fcec1 
…), follow-up google#1839).
tmatth pushed a commit to tmatth/oss-fuzz that referenced this pull request Oct 22, 2018
@inferno-chromium @tmatth
Revert "[infra] Remove srcmap related commands from gcb script (follo…
b93e8c0 
…w-up google#1839)." (google#1848)

This reverts commit f132eaf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverchang oliverchang oliverchang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dor1s @pdknsk @oliverchang