[alembic] Initial integration #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit gets Alembic building properly by linking it against a locally compiled checkout of the most recent OpenEXR release.
alsophian
suggested changes
Aug 4, 2020
spq
suggested changes
Aug 6, 2020
rjotwani
added a commit
to rjotwani/oss-fuzz
that referenced
this pull request
Aug 6, 2020
spq
approved these changes
Aug 6, 2020
alsophian
suggested changes
Aug 6, 2020
inferno-chromium
pushed a commit
that referenced
this pull request
Aug 7, 2020
* using tidy_html5's fuzzer_temp_file utilities to create a file from fuzzing input in /tmp * used FuzzerTemporaryFile class, updated copyright year * catch all exceptions instead of a select few, fix styling in openexr_exrheader_fuzzer * updating fuzzer_temp_file.h with the changes mentioned in #4236
mbarbella-chromium
suggested changes
Aug 10, 2020
There was a problem hiding this comment.
Followed up on chat to discuss some potential solutions for the build failure, but I suspect it would be reproducible in a ubsan build with the vptr check enabled. Once that's fixed (either by resolving the bug or temporarily disabling ubsan) I think this looks fine to land.
mbarbella-chromium
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrating alembic using this fuzzer. Opening this PR as a draft until @alsophian and @spq get a chance to review.
This PR closes alembic/alembic/issues#233.